Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

27 errors when building with @tsconfig/node18-strictest #322

Open
ms270169 opened this issue Sep 20, 2022 · 2 comments · May be fixed by #323
Open

27 errors when building with @tsconfig/node18-strictest #322

ms270169 opened this issue Sep 20, 2022 · 2 comments · May be fixed by #323

Comments

@ms270169
Copy link

ms270169 commented Sep 20, 2022

When using emailjs in a project with typescript settings based on @tsconfig/node18-strictest-esm, a build creates 27 errors on this modules.

@zackschuster
Copy link
Collaborator

part of this is adding support for the new exactOptionalPropertyTypes option, and part of this is your config just being stricter than ours 😂. really it just looks like it wants us to add a bunch of defensive checks. i'm looking into addressing this now.

for reference, here is our compiler options:

{
	"lib": [
		"es2017"
	],
	"target": "es2017",
	"module": "esnext",
	"moduleResolution": "node",
	"downlevelIteration": true,
	"esModuleInterop": true,
	"noFallthroughCasesInSwitch": true,
	"noImplicitReturns": true,
	"noUnusedLocals": true,
	"noUnusedParameters": true,
	"removeComments": true,
	"resolveJsonModule": true,
	"sourceMap": true,
	"strict": true
}

@eleith heads up as addressing this may have a minor perf effect

@arnonrdp
Copy link

Has same problem.
Solved changing from vue-cli to Vite.

(ps.: only did this because I am working in a very small repo)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants