Two fixes to thriftpy_gevent_worker.py for py3 compat #50
Conversation
aawilson
force-pushed
the
49/gevent_python_3
branch
from
8db8366
to
5cc8b6b
Compare
|
In the process of fixing the tests |
aawilson
force-pushed
the
49/gevent_python_3
branch
2 times, most recently
from
edabd96
to
be8a4c6
Compare
|
Test requirements updated. Note that this PR changes py27 requirements to use gevent 1.2(.2), and the env requirement to remove the <1.2 guard. If there's some reason I'm missing that would make that a bad idea, it's highly likely they can both be set back down to the lower version, but it should be fine as long as you're reasonably sure this project's tests exercise what they need to exercise. Will probably need a version increment, but I'm not familiar enough with this project's standards to know what your bar is for that, or whether it belongs in the PR itself. |
First fix: Wrap low-level "thread" import with try-except to fallback to the Python 3-specific "_thread" module. Second fix: Remove now-obsolete tuple-unpacking syntax from _greenlet_switch_tracer method signature, and replace with vesion-agnostic tuple unpack in method body README updated and py27 test markers removed from thriftpy_gevent worker test
aawilson
force-pushed
the
49/gevent_python_3
branch
from
be8a4c6
to
f7e3c88
Compare
|
@wooparadog Any chance this can get looked at? I'd like to stop using a github reference in my requirements files. |
|
@aawilson Thanks for your contribution, sorry about not having time to look at your pull request. But I'll look into it within this week. |
First fix: Wrap low-level "thread" import with try-except to fallback to
the Python 3-specific "_thread" module.
Second fix: Remove now-obsolete tuple-unpacking syntax from
_greenlet_switch_tracer method signature, and replace with
vesion-agnostic tuple unpack in method body.