Skip to content
This repository has been archived by the owner on Dec 10, 2018. It is now read-only.

Recursive structs no longer supported #144

Closed
gladhorn opened this issue Jul 4, 2015 · 4 comments
Closed

Recursive structs no longer supported #144

gladhorn opened this issue Jul 4, 2015 · 4 comments

Comments

@gladhorn
Copy link

gladhorn commented Jul 4, 2015

Thrift structures referencing themselves are no longer supported.

struct RecursiveType { 1: string data, 2: list<RecursiveType> tree }

used to work with Thriftpy 0.1.15 but do no longer work with 0.3.1.
This is a regression. Sadly the official Python thrift bindings also don't support this. Other language bindings do though.

@lxyu
Copy link
Contributor

lxyu commented Jul 6, 2015

@hit9

@hit9
Copy link
Contributor

hit9 commented Jul 6, 2015

Thrift is not like C, this feature is currently not in use (in our company).

@lxyu, should we implement it?

@hit9
Copy link
Contributor

hit9 commented Jul 6, 2015

@gladhorn And... Pull request accepted..

@hit9 hit9 added the wontfix label Jul 30, 2015
@hit9 hit9 closed this as completed Jul 30, 2015
@hit9 hit9 reopened this Aug 27, 2015
@hit9
Copy link
Contributor

hit9 commented Aug 27, 2015

We are ready to accept the "recursive self referencing structs definition" now

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants