support TCompactProtocol #159

Closed
wants to merge 11 commits into
from

Conversation

Projects
None yet
3 participants
@caorong
Contributor

caorong commented Oct 7, 2015

No description provided.

@lxyu

This comment has been minimized.

Show comment
Hide comment
@lxyu

lxyu Oct 10, 2015

Contributor

It seems to be directly moved from the upstream Apache, which means many code can be simplified in a more pythonic way, including logic, naming and style..

Contributor

lxyu commented Oct 10, 2015

It seems to be directly moved from the upstream Apache, which means many code can be simplified in a more pythonic way, including logic, naming and style..

@caorong

This comment has been minimized.

Show comment
Hide comment
@caorong

caorong Oct 10, 2015

Contributor

you are right, I will take some time to fix it..

Contributor

caorong commented Oct 10, 2015

you are right, I will take some time to fix it..

@caorong

This comment has been minimized.

Show comment
Hide comment
@caorong

caorong Oct 13, 2015

Contributor

@lxyu plz merge, we need this feature recently.

Contributor

caorong commented Oct 13, 2015

@lxyu plz merge, we need this feature recently.

@lxyu

This comment has been minimized.

Show comment
Hide comment
@lxyu

lxyu Oct 13, 2015

Contributor

@caorong sorry I may not able to merge this in a short time, since support a protocol requires more time to do improvements and testing.

I'd recommend you to put this protocol implementation in client side code base and use it with thriftpy or do some monkey_patch magic, if you need this feature recently.

Contributor

lxyu commented Oct 13, 2015

@caorong sorry I may not able to merge this in a short time, since support a protocol requires more time to do improvements and testing.

I'd recommend you to put this protocol implementation in client side code base and use it with thriftpy or do some monkey_patch magic, if you need this feature recently.

@caorong

This comment has been minimized.

Show comment
Hide comment
@caorong

caorong Oct 13, 2015

Contributor

@lxyu 👍

Contributor

caorong commented Oct 13, 2015

@lxyu 👍

@mariusvniekerk

This comment has been minimized.

Show comment
Hide comment
@mariusvniekerk

mariusvniekerk Jan 21, 2016

Anything that I can help with to get this merged?

Anything that I can help with to get this merged?

@lxyu

This comment has been minimized.

Show comment
Hide comment
@lxyu

lxyu Jan 22, 2016

Contributor

Yah just noticed the PR updated. I'll put it in the review process, hopefully get it merged in next week.

Contributor

lxyu commented Jan 22, 2016

Yah just noticed the PR updated. I'll put it in the review process, hopefully get it merged in next week.

lxyu added a commit that referenced this pull request Feb 16, 2016

@lxyu

This comment has been minimized.

Show comment
Hide comment
@lxyu

lxyu Feb 16, 2016

Contributor

Merged in 391921b

Thanks for contribution!

Contributor

lxyu commented Feb 16, 2016

Merged in 391921b

Thanks for contribution!

@lxyu lxyu closed this Feb 16, 2016

@lxyu lxyu referenced this pull request Feb 16, 2016

Closed

support TCompactProtocol #82

@pyup-bot pyup-bot referenced this pull request in scieloorg/opac_proc Aug 18, 2016

Closed

Initial Update #10

@pyup-bot pyup-bot referenced this pull request in scieloorg/scielo-manager Aug 26, 2016

Closed

Pin thriftpy to latest version 0.3.9 #1314

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment