init() now directly stores a copy of locals(). #163

Merged
merged 1 commit into from Oct 12, 2015

Conversation

Projects
None yet
2 participants
@jparise
Contributor

jparise commented Oct 10, 2015

We always start with an empty dict, and the dict.copy() method appears to
be a bit faster than dict.update().

Also, 'self' always exists in locals() so we can just delete that key directly
(instead of calling dict.pop()).

init() now directly stores a copy of locals().
We always start with an empty __dict__, and the dict.copy() method appears to
be a bit faster than dict.update().

Also, 'self' always exists in locals() so we can just delete that key directly
(instead of calling dict.pop()).

lxyu added a commit that referenced this pull request Oct 12, 2015

Merge pull request #163 from jparise/init-dict
init() now directly stores a copy of locals().

@lxyu lxyu merged commit ddeeb36 into eleme:develop Oct 12, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lxyu

This comment has been minimized.

Show comment
Hide comment
@lxyu

lxyu Oct 12, 2015

Contributor

Thanks!

Contributor

lxyu commented Oct 12, 2015

Thanks!

@jparise jparise deleted the jparise:init-dict branch Jun 23, 2016

@pyup-bot pyup-bot referenced this pull request in scieloorg/opac_proc Aug 18, 2016

Closed

Initial Update #10

@pyup-bot pyup-bot referenced this pull request in scieloorg/scielo-manager Aug 26, 2016

Closed

Pin thriftpy to latest version 0.3.9 #1314

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment