This repository has been archived by the owner on Dec 10, 2018. It is now read-only.
patch samefile method for windows user whos python version under 3.2 #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@halfcrazy can you add a test for this please? |
|
@lxyu It seems travis-ci does not support specify os like windows. It may difficult to write an unit test. |
|
ok, then have you tested this patch in windows env to make sure it works? |
|
@lxyu I'll test this weekend. LOL |
|
@lxyu This patch works under window7 python2.7 |
halfcrazy
changed the title
lxyu
added a commit
that referenced
this pull request
Dec 14, 2015
patch samefile method for windows user whos python version under 3.2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #133
https://github.com/python/cpython/blob/3.2/Lib/ntpath.py#L20
https://github.com/python/cpython/blob/3.1/Lib/ntpath.py#L19
As links shown above, we could found the samefile method was included since 3.2 on windows.
need to be tested