This repository has been archived by the owner on Dec 10, 2018. It is now read-only.
fix set_timeout only works before TSocket().open() #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lxyu
added a commit
that referenced
this pull request
Mar 17, 2016
…socket_open fix set_timeout only works before TSocket().open()
|
👍 |
| @@ -78,6 +78,9 @@ def set_timeout(self, ms): | |||
| self.socket_timeout = ms / 1000 if (ms and ms > 0) else None | |||
| self.connect_timeout = self.socket_timeout | |||
|
|
|||
| if self.sock is not None: | |||
| self.sock.settimeout(self.socket_timeout) | |||
There was a problem hiding this comment.
嗯...这个设置到原生socket上了 ，但是socket之后设置timeout就进入非阻塞模式了？有影响吧？
There was a problem hiding this comment.
怎么会？设多少次都不会变成非阻塞模式吧。。。除非设为 0.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.