This repository has been archived by the owner on Dec 10, 2018. It is now read-only.
Faster parse #30
Merged
Faster parse #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Group all elements we want to parse in one parser so that we can parse the thrift file in one go.
| for parse_results, _, _ in parser.scanString(schema): | ||
| for res in parse_results: | ||
| if res.getName() == 'typedefs': | ||
| result[res.getName()][res.name] = res.ttype |
There was a problem hiding this comment.
这里的 res.getName() 直接换成 typedefs 是不是更好些?
There was a problem hiding this comment.
@lxyu 嗯 会快一点 你比较熟悉这个数据结构的构造 能想到什么更简洁的方式来拼出来吗？
There was a problem hiding this comment.
不如这里直接 result[res.getName()].append(res)，统一到 load 里面处理？
There was a problem hiding this comment.
@lxyu load那边我还没细看，改动大吗？
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Group all elements we want to parse in one parser so that we can parse
the thrift file in one go.
@lxyu