small cleanup (#249)

* cleanup hardhat config * update forking file * remove whitespace * update workflow
delvtech · Mar 29, 2022 · 10e4370 · 10e4370
1 parent 2c22fff
commit 10e4370
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 6 deletions.
diff --git a/.env.sample b/.env.sample
@@ -0,0 +1 @@
+ALCHEMY_MAINNET_API_KEY=<ALCHEMY_KEY>
diff --git a/.github/workflows/cov.yaml b/.github/workflows/cov.yaml
@@ -15,7 +15,7 @@ jobs:
         - name: Install dependencies
           run: npm ci && npm run load-contracts
         - name: Coverage
-          run: npm run build && npm run coverage
+          run: export ALCHEMY_MAINNET_API_KEY=${{secrets.ALCHEMY_MAINNET_API_KEY}} && npm run build && npm run coverage
         - name: Edit lcov.info
           run: cat coverage/lcov.info | sed '/.*\/balancer-core-v2\/.*/,/TN:/d' | sed '/.*\/test\/.*/,/TN:/d' | sed '/.*\/zaps\/.*/,/TN:/d' > coverage/tmp.info && mv coverage/tmp.info coverage/lcov.info
         - name: Coveralls

diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml
@@ -18,7 +18,9 @@ jobs:
         - name: compile
           run: npx hardhat compile
         - name: test
-          run: npm run test
+          run:
+            export ALCHEMY_MAINNET_API_KEY=${{secrets.ALCHEMY_MAINNET_API_KEY}}
+            npm run test
     sim:
       runs-on: ubuntu-latest
       steps:
@@ -28,7 +30,9 @@ jobs:
         - name: compile
           run: npx hardhat compile
         - name: simulation
-          run: npm run sim
+          run:
+            export ALCHEMY_MAINNET_API_KEY=${{secrets.ALCHEMY_MAINNET_API_KEY}}
+            npm run sim
     typecheck:
       runs-on: ubuntu-latest
       steps:

diff --git a/.gitignore b/.gitignore
@@ -11,3 +11,4 @@ coverage/
 contracts/balancer-core-v2
 balancer-core-v2
 test/simulation/analysis/
+.env
diff --git a/hardhat.config.ts b/hardhat.config.ts
@@ -73,7 +73,7 @@ const config: HardhatUserConfig = {
   networks: {
     hardhat: {
       forking: {
-        url: "https://eth-mainnet.alchemyapi.io/v2/kwjMP-X-Vajdk1ItCfU-56Uaq1wwhamK",
+        url: `https://eth-mainnet.alchemyapi.io/v2/${process.env.ALCHEMY_MAINNET_API_KEY}`,
         blockNumber: 11853372,
       },
       accounts: {

diff --git a/test/helpers/forking.ts b/test/helpers/forking.ts
@@ -6,8 +6,7 @@ export const setBlock = async (block: number) => {
     params: [
       {
         forking: {
-          jsonRpcUrl:
-            "https://eth-mainnet.alchemyapi.io/v2/kwjMP-X-Vajdk1ItCfU-56Uaq1wwhamK",
+          jsonRpcUrl: `https://eth-mainnet.alchemyapi.io/v2/${process.env.ALCHEMY_MAINNET_API_KEY}`,
           blockNumber: block,
         },
       },