New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Scrim style to Compound #297

Open

4 tasks

gaelledel opened this issue Jan 16, 2024 · 3 comments

Assignees

Labels

T-Component-Design

gaelledel commented Jan 16, 2024

Figma document

...
Does not exist yet

Platform

...

Design phase

Beta Give feedback

Component exists on Figma
Component is documented in the component library
Component is tested for theming
Component shareout for designers
Options

gaelledel added the T-Component-Design label

Collaborator

americanrefugee commented Jan 26, 2024

I created a new Compound component @gaelledel :
https://www.figma.com/file/rTaQE2nIUSLav4Tg3nozq7/Compound-Web-Components?type=design&node-id=3623-42399&mode=design&t=yec5Q2ioPs2Oy5Wr-4

Can you take a look and let me know if you agree or disagree with the color values / transparency applied?

Author

gaelledel commented Jan 30, 2024

Thanks, I would bring the transparency down to 30% on Light mode - the dark one looks fine as it is

americanrefugee assigned robintown

Collaborator

americanrefugee commented Jan 30, 2024

@gaelledel I've updated the scrim for Light mode.

@robintown this is now ready to formalize in code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment