Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proximity sensor works after call finished #2467

Closed
szewdev opened this issue Nov 28, 2020 · 7 comments · Fixed by #4728
Closed

Proximity sensor works after call finished #2467

szewdev opened this issue Nov 28, 2020 · 7 comments · Fixed by #4728
Labels
A-VoIP O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@szewdev
Copy link

szewdev commented Nov 28, 2020

Describe the bug
Proximity sensor is still enabled after the call ends.

To Reproduce
Steps to reproduce the behavior:

  1. End VoIP call
  2. Hide sensor with your hand
  3. Screen gets black
  4. Have to uninstall app (killing process is not enough) to dis ale proximity sensor

Expected behavior
Disable proximity sensor after call finished

@bmarty bmarty added the A-VoIP label Dec 2, 2020
@kittykat
Copy link
Contributor

I'm going to close this issue as the proximity sensor is actually disabled during video calls and we cannot reproduce the issue. The issue may be hardware specific so if you're still seeing it, please reply with @kittykat and more information, and I will be happy to re-open it for you 👍

@532910
Copy link
Contributor

532910 commented Nov 17, 2021

Video calls weren't the problem. Proximity sensor should be used during an audio call, and it's not released every time. It doesn't happen every time and it's hard to reproduce.

@Luciogi
Copy link

Luciogi commented Dec 14, 2021

This issue is still produce-able on my device (Redmi 9t) [release 1.3.9], but not on other device (Honor 9c).
Force killing app only way to disable proximity sensor
I have sent bug reports within application.
Can you make an option in setting that will let user to enable or disable proximity sensor during call ?
@kittykat

Edit:
I have tested voice calling on TRIfA (a tox client). It did release proximity sensor. This confirmed that it is not hardware issue with my device

@kittykat kittykat reopened this Dec 14, 2021
@kittykat kittykat added this to Incoming in Issue triage Dec 14, 2021
@kittykat
Copy link
Contributor

@Luciogi I see two rageshakes (log submissions through the app) which I believe are yours. One is from v1.3.7 three days ago and another from v1.3.9 two days ago. Is that correct?

I have attached both to this issue, and put the issue onto the team's triage board so it can be prioritised and investigated.

@Luciogi
Copy link

Luciogi commented Dec 14, 2021

I have just sent bug report also include that , may be reports you mentioned could not be mine.

@ouchadam ouchadam added O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems labels Dec 15, 2021
@ouchadam
Copy link
Contributor

I have a suspicion this is caused by us always attempting to acquire wake locks and not checking if we already have one, will raise a tentative fix

https://github.com/vector-im/element-android/blob/develop/vector/src/main/java/im/vector/app/features/call/CallProximityManager.kt#L96

@ouchadam ouchadam moved this from Incoming to Triaged in Issue triage Dec 15, 2021
@ouchadam ouchadam added this to In Code Review in Android App Team Dec 15, 2021
Issue triage automation moved this from Triaged to Closed Dec 15, 2021
Android App Team automation moved this from In Code Review to Merged Dec 15, 2021
@bmarty
Copy link
Member

bmarty commented Dec 15, 2021

Fixed in EA 1.3.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-VoIP O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
Development

Successfully merging a pull request may close this issue.

6 participants