Notification does not vanish if the message is read on another session

[bmarty]

• Bob has 2 sessions: one on Element Android, one on Element Web, and share a room with Alice.
• Bob is viewing the room list on Element Android
• Alice sends a message to Bob in room A
• The notification appears on Bob's Android device.
• Bob read the room in his Element Web session
• The notification is still visible to Bob's Android device -> KO

The notification should be cancel on Bob's Android device.

It used to work, so this is regression.

During the while process Element Android is in foreground (so is syncing permanently). If Element Android app goes to background, I'm not sure we will receive a Push to update the read marker of Bob, but it is acceptable in this case.

[bmarty]

I've noticed that the notification of one room is not dismissed when we open the room on the same device, which is probably a related issue.

[ouchadam]

I've been unable to reproduce, using a Google Play variant with the latest from develop cfd37bb and testing on a Pocofone f1 (API 29) and Samsung Fold (API 30) the notification correctly dismisses when focusing on the web client.

The notification also dismisses whilst in the app is in the background and the web client gains focus.

[ouchadam]

I think I've found the cause, other than having an invalid session or removing the room this is the only way I've been able to reproduce 🤞

the current logic relies on all the notification events existing within the same last chunk which means if a user gets enough messages in their timeline to start a new chunk it's now impossible for the app to match against the older events (the notification is cleared when all events for a roomId have been filtered by isMessageOutdated which solely relies on the last chunk)

• filtering notification events if they're outdated

• notification is removed when all events for the room have been filtered

• expecting the event to be in the last chunk

• creating a new chunk doesn't have the previous events

tl;dr high traffic rooms cause us to lose track of the event id to remove

this might be the source of the regression