Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space | A removed room from a space can't be re-added as it won't be shown in add-room #3947

Closed
BillCarsonFr opened this issue Sep 1, 2021 · 1 comment · Fixed by #4000
Assignees
Labels
A-Spaces Spaces, groups, communities T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@BillCarsonFr
Copy link
Member

Steps to reproduce

  1. Create a new space with 3 default rooms
  2. Go to manage rooms and remove the room
  3. Try to go to add room to add it back

What did you expect?

Expected the removed room to show up

What happened?

The removed room is not shown in the add candidates

Your phone model

No response

Operating system version

No response

Application version and app store

No response

Homeserver

No response

Have you submitted a rageshake?

No

@BillCarsonFr BillCarsonFr added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems A-Spaces Spaces, groups, communities labels Sep 1, 2021
@BillCarsonFr
Copy link
Member Author

It's due to an inproper use of m.space parent relation by EA.
EA will create the default room with a state event m.space.parent pointing to the parent space, as a consequence the actual code considers it to be part of the space

This is not how m.space.parent should work, this is some legacy code done during dev, and should be removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Spaces Spaces, groups, communities T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant