Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a dedicated module for translations to be able to use strings from sub modules #3955

Closed
bmarty opened this issue Sep 2, 2021 · 1 comment · Fixed by #6774
Closed

Create a dedicated module for translations to be able to use strings from sub modules #3955

bmarty opened this issue Sep 2, 2021 · 1 comment · Fixed by #6774
Assignees
@ouchadam
Labels
A-DevX Anything that can improve the DevX Z-Maintenance Z-Modularization

Comments

@bmarty
Copy link
Member

bmarty commented Sep 2, 2021 •
edited

Weblate configuration will have to be updated.

It will also probably break the forks which have changes in the translation, so please also add a documentation to help migrating the forks.

It could also be good for the iterative compilation time.

Be careful with this:

apply plugin: 'placeholder-resolver'
@bmarty bmarty added this to the Sprint - Element 1.3.4 milestone Oct 15, 2021
@bmarty bmarty self-assigned this Oct 15, 2021
@bmarty bmarty mentioned this issue Oct 15, 2021
Closed
@bmarty
Copy link
Member Author

bmarty commented Oct 18, 2021

Blocked by LikeTheSalad/android-stem#14

@bmarty bmarty removed this from the Sprint - Element 1.3.4 milestone Oct 20, 2021
@ouchadam ouchadam assigned ouchadam and unassigned bmarty Aug 8, 2022
@ouchadam ouchadam mentioned this issue Aug 8, 2022
Merged
6 tasks
@ouchadam ouchadam added this to In Code Review in Android App Team Aug 9, 2022
@ouchadam ouchadam removed this from In Code Review in Android App Team Aug 9, 2022
@ouchadam ouchadam added the A-DevX Anything that can improve the DevX label Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ouchadam ouchadam

Labels
A-DevX Anything that can improve the DevX Z-Maintenance Z-Modularization
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dedicated module for strings element-hq/element-android
3 participants
@ouchadam @bmarty @manuroe