Feature/fga/improve room detail start #4065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
September 21, 2021 18:31
|
|
||
| class LifecycleAwareLazy<out T>( | ||
| private val owner: LifecycleOwner, | ||
| initializer: () -> T |
bmarty
reviewed
Sep 23, 2021
| return getOrInflate(inflateIfNeeded, roomDetailBinding?.inviteViewStub, this::inviteView) | ||
| } | ||
|
|
||
| private inline fun <reified T : View> getOrInflate(inflateIfNeeded: Boolean, stub: ViewStub?, reference: KMutableProperty0<T?>): T? { |
There was a problem hiding this comment.
This could be extracted to a more generic place
There was a problem hiding this comment.
Will see if we reuse this mechanism somewhere else I guess, no?
There was a problem hiding this comment.
Yes, but if it is hidden here, there is less chance. Anyway, ok
| @@ -43,13 +44,13 @@ import kotlin.math.abs | |||
| * TODO: Performances | |||
There was a problem hiding this comment.
It doesn't really improve performance on this screen, so not really
|
Yes I tested the different screens using emojis, all ok. |
bmarty
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to improve performance on RoomDetail screen by: