Remove redundancy in heading in bug report issue form #4076
Conversation
Also made the subheadings one size smaller (4 #'s instead of 3)
|
@bmarty should we also sync this with iOS? https://github.com/vector-im/element-ios/blob/develop/.github/ISSUE_TEMPLATE/bug.yml |
.github/ISSUE_TEMPLATE/bug.yml
Outdated
| @@ -23,12 +23,12 @@ body: | |||
| - type: textarea | |||
| id: result | |||
| attributes: | |||
| label: What happened? | |||
| label: Intended vs. Actual Result | |||
There was a problem hiding this comment.
Please keep capitalisation consistent with other labels
I'd prefer to use "and" instead of "vs." because it's better practice to use simpler words and no abbreviation when writing for an international audience
There was a problem hiding this comment.
Done. Is it so that those who use online translators get better translations?
Yes, please submit the same changes for element-ios and element-web (which has two forms) after this one is finalised and add me as the reviewer for those |
There was a problem hiding this comment.
@opusforlife2 will you update this PR? Else I'm afraid we will close it.
@kittykat Is this addressed to me?
@bmarty I'm here on weekends only. Since you guys have the weekend off, there is bound to be a mismatch between our work times, sadly. |
opusforlife2
changed the title
|
@opusforlife2 thanks for the update! |
I think so, yes :)
Sure, sorry for my unnecessary pressure. We are trying to reduce the number of opened (and sometimes staled) PRs. |
|
I let @kittykat approve and merge the PR |
Based off element-hq/element-android/pull/4076, trying out slightly different wording Signed-off-by: Ekaterina Gerasimova <ekaterinag@element.io>
|
@opusforlife2 I'm trying out slightly different wording in element-web, can you have a look at that and see what you think? Please submit a PR for element-ios and add me as a reviewer :) |
Based off element-hq/element-android/pull/4076, trying out slightly different wording Signed-off-by: Ekaterina Gerasimova <ekaterinag@element.io>
@kittykat The URL you linked says "Page not found". Typo in the PR number?
Alright. Going to check out the template. |
|
@opusforlife2 I've updated the link, do you want to check it out? Or here for the generated template |
|
@kittykat I've submitted the Element-iOS PR, and checked out your PR in Element-Web. Aside from that, why does the bug template here have a placeholder saying "Element version x.x.x, olm version x.x.x from F-Droid"? Shouldn't it just be the Element Android version? |
Pull Request Checklist
The issue form currently generates a bug report that contains the "What happened?" heading twice. See #4047 (comment).
This PR edits the culprit heading and its subheadings to remove the redundancy and clarify what is meant.