Make the font size selection dialog scrollable #4201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrap the LinearLayout inside a ScrollView.
|
Thanks for the PR, can you add a file for the changelog as per https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog please? |
|
Sure, I added |
bmarty
approved these changes
Oct 11, 2021
| android:id="@+id/text_selection_tiny_text_view" | ||
| android:layout_height="match_parent"> | ||
| <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android" | ||
| xmlns:tools="http://schemas.android.com/tools" |
There was a problem hiding this comment.
xmlns declaration can be removed from this LinearLayout now.
|
Can you also check the error(s) reported by the CI please? Thanks! |
bmarty
approved these changes
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On small devices, it is difficult to pick the "Huge" font size, as the list is not scrollable.
This trivial PR wraps the
LinearLayoutin aScrollView.Pull Request Checklist
I can provide a screenshot, but I don't know what to show.
Signed-off-by: David Terrell jeltz+github@auro.re