Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recurrence of #2605: Tapping drawer having more than one room in notifications gives "malformed link" error #4267

Closed
scottwallacesh opened this issue Oct 19, 2021 · 8 comments
Assignees
Labels
A-Notifications O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems X-Regression

Comments

@scottwallacesh
Copy link

Steps to reproduce

  1. Where are you starting? Notification drawer.
  2. What do you click? The Element notification with more than one room included.
  3. A box appears with "The link was malformed".

Intended result and actual result

What did you expect?

To be taken to the first room with unread messages.

What happened instead?

A message popped up with "The link was malformed". Clearing the message goes to the Element app.

Your phone model

Google Pixel 4a

Operating system version

Android 11

Application version and app store

Element v1.3.3 from Google Play Store

Homeserver

wallace.sh

Will you send logs?

No

@scottwallacesh scottwallacesh added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Oct 19, 2021
@scottwallacesh
Copy link
Author

Potentially related to commit e37fb313.

@RiotRobot RiotRobot added this to Incoming in Issue triage Oct 19, 2021
@anoadragon453
Copy link
Member

anoadragon453 commented Oct 19, 2021

Screenshot of the issue.

@bmarty bmarty added A-Notifications O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist X-Regression labels Oct 19, 2021
@bmarty bmarty moved this from Incoming to Triaged in Issue triage Oct 19, 2021
@bmarty bmarty added this to Backlog (Unsorted) in Android App Team Oct 19, 2021
@bmarty
Copy link
Member

bmarty commented Oct 19, 2021

I can repro

@ouchadam
Copy link
Contributor

Also seeing this when tapping room invitation notifications

before-join-notification

@ouchadam
Copy link
Contributor

ouchadam commented Oct 22, 2021

sorry to be a pain 😅 I would question this UX

What did you expect?
To be taken to the first room with unread messages.

Using gmail as an example, tapping a group of emails takes the user to the inbox rather than an individual email.
I'd be interested to know how other messaging apps handle this 🤔

I'd lean more towards the grouped notification launching the DM or Room list, android allows us to expand notification groups to select a specific one if we do want to action a certain notification.

cc @daniellekirkwood


in case we're happy with only opening the home screen #4320

@ouchadam ouchadam self-assigned this Oct 22, 2021
@ouchadam ouchadam moved this from Next Sprint to Current Sprint in Android App Team Oct 22, 2021
@ouchadam ouchadam moved this from Current Sprint to In progress in Android App Team Oct 22, 2021
@opusforlife2
Copy link
Contributor

@ouchadam That seems like the correct behaviour. Whatsapp does it the way you lay it out.

@ouchadam ouchadam moved this from In progress to In Code Review in Android App Team Oct 25, 2021
@daniellekirkwood
Copy link
Contributor

@ouchadam Yes!

  • If the user taps the group of notifications take them to the home page.
  • If the user expands the notification group and selects a particular message, take them to that room.

@ouchadam
Copy link
Contributor

in that case we can close this ^^^

will be part of the 1.3.5 release

Issue triage automation moved this from Triaged to Closed Oct 25, 2021
Android App Team automation moved this from In Code Review to Merged Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Notifications O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems X-Regression
Projects
Development

No branches or pull requests

6 participants