Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort SSO providers by relevance #4277

Closed
bmarty opened this issue Oct 20, 2021 · 1 comment · Fixed by #4379
Closed

Sort SSO providers by relevance #4277

bmarty opened this issue Oct 20, 2021 · 1 comment · Fixed by #4379
Assignees
Labels
A-SSO O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Tolerable Low/no impact on users T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-D1 Issue impacts D1 metric Z-Papercuts Visible. Impactful. Predictable to action.

Comments

@bmarty
Copy link
Member

bmarty commented Oct 20, 2021

Currently, on matrix.org, we display this:

image

SSO providers are not sorted by relevance, and non tech users may wonder what is GitHub?

The code is already there because it has been done on LoginFlowV2 experimentation - sorted() added here and on 1 other place too, but LoginFlowV2 is not activated yet, and will require more work.

The Quick Win is to sort also on LoginFlowV1

@bmarty bmarty added musthave T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-Papercuts Visible. Impactful. Predictable to action. S-Critical Prevents work, causes data loss and/or has no workaround O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience Z-D1 Issue impacts D1 metric labels Oct 20, 2021
@bmarty bmarty added this to Backlog (Unsorted) in Android App Team Oct 20, 2021
@RiotRobot RiotRobot added this to Incoming in Issue triage Oct 20, 2021
@bmarty bmarty added S-Tolerable Low/no impact on users and removed S-Critical Prevents work, causes data loss and/or has no workaround labels Oct 21, 2021
@kittykat kittykat added A-3PIDs S-Critical Prevents work, causes data loss and/or has no workaround S-Tolerable Low/no impact on users and removed S-Tolerable Low/no impact on users S-Critical Prevents work, causes data loss and/or has no workaround labels Oct 21, 2021
@bmarty
Copy link
Member Author

bmarty commented Oct 21, 2021

From the link above, the order will be

            // We are on Android, so user is more likely to have a Google account
            BRAND_GOOGLE   -> 5
            // Facebook is also an important SSO provider
            BRAND_FACEBOOK -> 4
            // Twitter is more for professionals
            BRAND_TWITTER  -> 3
            // Here it's very for techie people
            BRAND_GITHUB,
            BRAND_GITLAB   -> 2
            // And finally, if the account has been created with an iPhone...
            BRAND_APPLE    -> 1
            else           -> 0

@bmarty bmarty added A-SSO and removed A-3PIDs labels Oct 21, 2021
@kittykat kittykat moved this from Incoming to Triaged in Issue triage Oct 21, 2021
@bmarty bmarty moved this from Backlog (Unsorted) to Current Sprint in Android App Team Oct 25, 2021
@bmarty bmarty removed the musthave label Oct 27, 2021
@ouchadam ouchadam moved this from Current Sprint to In progress in Android App Team Nov 1, 2021
@ouchadam ouchadam self-assigned this Nov 1, 2021
@ouchadam ouchadam moved this from In progress to In Code Review in Android App Team Nov 1, 2021
Issue triage automation moved this from Triaged to Closed Nov 2, 2021
Android App Team automation moved this from In Code Review to Merged Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-SSO O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Tolerable Low/no impact on users T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-D1 Issue impacts D1 metric Z-Papercuts Visible. Impactful. Predictable to action.
Projects
Development

Successfully merging a pull request may close this issue.

3 participants