Fix incorrect cropping of conversation icons

[dkter]

Fixes #4417 (see that issue for screenshots)

Pull Request Checklist

• Changes has been tested on an Android device or Android emulator with API 21
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR
• If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

Signed-off-by: David Teresi dkteresi@gmail.com

[bmarty]

Hello, thanks for the PR.
@ouchadam can you have a look please? I'm not sure about the link between notification and shortcuts

[ouchadam]

it was part of the conflict resolution of #3313 to the notification redesign, if the logic isn't needed then that's great! 💯

There are also some unit tests to update

NotificationRendererTest.kt: (93, 17): Cannot find a parameter with this name: shortcutInfo
NotificationRendererTest.kt: (94, 17): Mixing named and positioned arguments is not allowed
NotificationRendererTest.kt: (95, 9): No value passed for parameter 'meta'

Once the CI is happy, I'm happy!