We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try to establish an olm session from an OTK of type fallback
Signature will fail, because the signable json is only using 'key' where it should use the all json and only remove unsigned and signatures.
Only happens with fallback key as a new fallback field is present in the dict:
fallback
{ "fallback": true, "key": "dQp6YuFhLbZ4...wBq2deKNmdpewSzc", "signatures": { "@XXXX:matrix.org": { "ed25519:EXRRRRRR": "R1NiKUQd+ZhvxMPZiFgcG/6Lm5.....h6RkF2+mdopOw+W8UB4YRBA" } } }
Current:
fun signalableJSONDictionary(): Map<String, Any> { return mapOf("key" to value) }
Expected from JS sdk:
// prepare the canonical json: remove unsigned and signatures, and stringify with anotherjson const mangledObj = Object.assign({}, obj); if ("unsigned" in mangledObj) { delete mangledObj.unsigned; } delete mangledObj.signatures; const json = anotherjson.stringify(mangledObj);
No response
No
The text was updated successfully, but these errors were encountered:
iOS equivalent element-hq/element-ios#5120
Sorry, something went wrong.
BillCarsonFr
Successfully merging a pull request may close this issue.
Steps to reproduce
Try to establish an olm session from an OTK of type fallback
Intended result and actual result
Signature will fail, because the signable json is only using 'key' where it should use the all json and only remove unsigned and signatures.
Only happens with fallback key as a new
fallback
field is present in the dict:Current:
Expected from JS sdk:
Your phone model
No response
Operating system version
No response
Application version and app store
No response
Homeserver
No response
Will you send logs?
No
The text was updated successfully, but these errors were encountered: