Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/aris/epoxy controller init improvement #4592

Merged
merged 2 commits into from Nov 30, 2021
Merged

Feature/aris/epoxy controller init improvement #4592

merged 2 commits into from Nov 30, 2021

Conversation

ariskotsomitopoulos
Copy link
Contributor

@ariskotsomitopoulos ariskotsomitopoulos commented Nov 30, 2021 •
edited

Remove requestModelBuild() from epoxy Controllers init{} block #4591

@ariskotsomitopoulos ariskotsomitopoulos self-assigned this Nov 30, 2021
@ariskotsomitopoulos ariskotsomitopoulos linked an issue Nov 30, 2021 that may be closed by this pull request
Remove requestModelBuild() from epoxy Controllers init block #4591
Closed
@ouchadam
Copy link
Contributor

I'm assuming removing this init doesn't break the pages? 🤞 do we know why it was originally added?

@ariskotsomitopoulos
Copy link
Contributor Author

ariskotsomitopoulos commented Nov 30, 2021 •
edited

I'm assuming removing this init doesn't break the pages? 🤞 do we know why it was originally added?

Yes, the app seems fine without them. I only didn't test SoftLogoutController.kt. No idea why they were added, I guess this started on timeline Controller that is an extreme case and we should use requestModelBuild() in the init there. And maybe after that it was just copy paste from this controller. Any extra thoughts are welcome

bmarty
bmarty approved these changes Nov 30, 2021
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@github-actions
Copy link

Unit Test Results

  66 files  ±0    66 suites  ±0   1m 1s ⏱️ +12s
135 tests ±0  135 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
418 runs  ±0  418 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit ff0cf9b. ± Comparison against base commit 8fd5e42.

@bmarty bmarty merged commit 02a6091 into develop Nov 30, 2021
@bmarty bmarty deleted the feature/aris/epoxy_controller_init_improvement branch November 30, 2021 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ouchadam ouchadam ouchadam approved these changes

@bmarty bmarty bmarty approved these changes

Assignees

@ariskotsomitopoulos ariskotsomitopoulos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove requestModelBuild() from epoxy Controllers init block
3 participants
@ariskotsomitopoulos @ouchadam @bmarty