Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot exit scan QR code without scanning a QR code #4644

Closed
3 tasks
daniellekirkwood opened this issue Dec 6, 2021 · 5 comments · Fixed by #4871
Closed
3 tasks

Cannot exit scan QR code without scanning a QR code #4644

daniellekirkwood opened this issue Dec 6, 2021 · 5 comments · Fixed by #4871
Assignees
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-WTF WTF moment: High Impact, Low Effort

Comments

@daniellekirkwood
Copy link
Contributor

daniellekirkwood commented Dec 6, 2021

This issue is: Ready to be Built

Problem

When a user wants to add another user by scanning the QR code, the full screen camera takeover appears. This view cannot be closed - the user must scan a QR code which can be annoying if they clicked there by accident.
The only way I found to close this view was to force quit the app.

Current Screens
DM QR code

Solution

Add a material.io top bar (contextual action bar) with a title and close button that takes the user back to the previous screen.

Something like this:
Screenshot 2021-12-07 at 11 19 59


Edit bmarty TODO:
For all the titles to add you can reuse an existing string

  • Add a title to the screen CreateDirectRoomByQrCodeFragment (see above)
  • Add a title "Scan a QR code" to the screen ScanUserCodeFragment
  • Add a title "Scan their code" to the screen QrCodeScannerFragment
@daniellekirkwood daniellekirkwood added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-WTF WTF moment: High Impact, Low Effort labels Dec 6, 2021
@RiotRobot RiotRobot added this to Incoming in Issue triage Dec 6, 2021
@bmarty
Copy link
Member

bmarty commented Dec 7, 2021

Using the regular back button should work, but it,s maybe a bit hidden on new Android system.

Can you add a screenshot please?

@daniellekirkwood
Copy link
Contributor Author

Confirmed, the "back swipe" gesture works on Android but this action can be disabled so its best not to rely on it

@bmarty
Copy link
Member

bmarty commented Dec 7, 2021

If you disable the back gesture then you should have the regular back/home/switch navigation buttons displayed at the bottom of the screen.

But I agree it will be better with a toolbar anyway.

@bmarty
Copy link
Member

bmarty commented Dec 7, 2021

Thanks for the screenshots by the way, here they helped me to understand that you were not talking about QR code scanning for user verification :)

@ouchadam ouchadam moved this from Incoming to Triaged in Issue triage Dec 9, 2021
@daniellekirkwood daniellekirkwood added this to Next Sprint in Android App Team Dec 13, 2021
@bmarty bmarty moved this from Next Sprint to Current Sprint: Dec 13 - Jan 11th in Android App Team Jan 5, 2022
Issue triage automation moved this from Triaged to Closed Jan 6, 2022
Android App Team automation moved this from Current Sprint: Dec 13 - Jan 11th to Merged Jan 6, 2022
@bmarty
Copy link
Member

bmarty commented Jan 6, 2022

In EA 1.3.13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-WTF WTF moment: High Impact, Low Effort
Projects
Development

Successfully merging a pull request may close this issue.

3 participants