Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment only on ktlint fail #4888

Merged

Conversation

ariskotsomitopoulos
Copy link
Contributor

@ariskotsomitopoulos ariskotsomitopoulos commented Jan 10, 2022

This PR will contain the following changes:

  • Do not add GitHub comments on successful ktlint runs
  • Remove already existing comments when ktlint succeed

 - Remove already existing comments when ktlint succeed
@ariskotsomitopoulos ariskotsomitopoulos force-pushed the feature/aris/linter__remove_github_comment_on_success branch from 0674772 to 71fbc3c Compare January 10, 2022 11:07
@ariskotsomitopoulos ariskotsomitopoulos added this to Inbox in Element Android PRs lifecycle via automation Jan 10, 2022
@ariskotsomitopoulos ariskotsomitopoulos marked this pull request as ready for review January 10, 2022 11:11
Element Android PRs lifecycle automation moved this from Inbox to Reviewer approved Jan 10, 2022
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change, thanks!

@bmarty bmarty enabled auto-merge January 10, 2022 11:21
@github-actions
Copy link

Unit Test Results

  66 files  ±0    66 suites  ±0   58s ⏱️ +5s
135 tests ±0  135 ✔️ ±0  0 💤 ±0  0 ±0 
418 runs  ±0  418 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 71fbc3c. ± Comparison against base commit 32f2e7d.

@bmarty bmarty disabled auto-merge January 10, 2022 13:44
@bmarty bmarty merged commit 10e8808 into develop Jan 10, 2022
Element Android PRs lifecycle automation moved this from Reviewer approved to Done Jan 10, 2022
@bmarty bmarty deleted the feature/aris/linter__remove_github_comment_on_success branch January 10, 2022 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants