Delete bunch of unused strings - WIP #5352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matrix SDKIntegration Tests Results:
|
BillCarsonFr
approved these changes
Feb 25, 2022
bmarty
force-pushed
the
feature/bma/delete_unused_strings
branch
from
dfc0182
to
561dcbc
Compare
|
Force pushed and git history rewritten. If CI is happy, this could be merged and Weblate synced and unlocked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all unused strings (about 700 strings removed). See the last file on this diff (value/strings.xml). Lots of strings were coming from Riot or has been replaced by other strings. I prefer to remove them all and add again later if necessary. The goal is to avoid translators (= real human!) to translate unused strings.
lint.xmlfile has been updated to ignore other sources of unused resources. Weblate is locked, so I want to focus on String here. Other unused resources can be handled later in a separate PR.Now unused strings will be considered as lint error, we may change this later, since PR cannot delete unused string, but mark them as to be deleted. We may just ignore those errors until the next Weblate sync, but this is not ideal.
WIP
All translations has been temporarily removed to work only on the original strings.
If the CI is happy, next step is to restore all the translations (revert first commit) and delete all the translations of deleted strings.
Once PR is merge, a sync with Weblate will be done and Weblate will be unlocked.