Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash upon accepting voice call #5421

Closed
opusforlife2 opened this issue Mar 4, 2022 · 4 comments
Closed

Crash upon accepting voice call #5421

opusforlife2 opened this issue Mar 4, 2022 · 4 comments
Assignees
Labels
A-VoIP matrix-sdk O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Crash

Comments

@opusforlife2
Copy link
Contributor

opusforlife2 commented Mar 4, 2022

Steps to reproduce

Element completely crashed when I accepted a voice call just now. I don't know if it's reproducible yet.

Specifically, the crash occurred when the call status changed to "Call connecting..."

Logs:

FATAL EXCEPTION: LIVE_ENTITY_BACKGROUND
Process: im.vector.app, PID: 12473
java.util.ConcurrentModificationException
	at java.util.ArrayList$Itr.next(ArrayList.java:860)
	at org.matrix.android.sdk.internal.session.call.CallEventProcessor.onPostProcess(CallEventProcessor.kt:2)
	at org.matrix.android.sdk.internal.database.EventInsertLiveObserver$onChange$2.invokeSuspend(EventInsertLiveObserver.kt:11)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:3)
	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:18)
	at android.os.Handler.handleCallback(Handler.java:883)
	at android.os.Handler.dispatchMessage(Handler.java:100)
	at android.os.Looper.loop(Looper.java:214)
	at android.os.HandlerThread.run(HandlerThread.java:67)

Outcome

What did you expect?

For the voice call to begin normally.

And for Element to offer to send a crash report upon restart.

What happened instead?

Neither. Element just crashed. The logs I've caught were through Scoop, so I've selected "No" for logs.

Your phone model

Xiaomi Mi 5

Operating system version

Android 10 (LOS 17.1)

Application version and app store

1.4.2 (F-Droid)

Homeserver

No response

Will you send logs?

No


EDIT by @ouchadam

We're also getting reports in the play store console with the exact same stacktrace

Occurrences (30 days) Total Occurrences Impacted users (lifetime)
143 149 125

https://play.google.com/console/u/0/developers/{redacted}/app/{redacted}/vitals/crashes/3c579fd0/details?installedFrom=PLAY_STORE&days=30

@opusforlife2 opusforlife2 added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Mar 4, 2022
@RiotRobot RiotRobot added this to Incoming in Issue triage Mar 4, 2022
@opusforlife2
Copy link
Contributor Author

Hello triage team.

@ouchadam ouchadam moved this from Incoming to Triaged in Issue triage Mar 22, 2022
@ouchadam ouchadam added S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Mar 22, 2022
@ouchadam
Copy link
Contributor

ouchadam commented Mar 22, 2022

marked as uncommon whilst there aren't any other reports, ConcurrentModificationException will be tricky to reproduce but we can definitely guard against it

it also looks like the backing list is accessed from multiple threads https://github.com/vector-im/element-android/blob/develop/matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/call/CallEventProcessor.kt

@ouchadam
Copy link
Contributor

I've found the same crash in the play store console, have edited the issue description to include the current stats

@ouchadam ouchadam added O-Occasional Affects or can be seen by some users regularly or most users rarely and removed O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Mar 23, 2022
@ouchadam ouchadam self-assigned this May 3, 2022
@ouchadam ouchadam added this to Next Sprint in Android App Team May 3, 2022
@manuroe manuroe moved this from Next Sprint to Current Sprint in Android App Team May 3, 2022
@ouchadam
Copy link
Contributor

ouchadam commented May 4, 2022

fixed in 1.4.14

@ouchadam ouchadam closed this as completed May 4, 2022
Issue triage automation moved this from Triaged to Closed May 4, 2022
Android App Team automation moved this from Current Sprint to Merged May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-VoIP matrix-sdk O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Crash
Projects
Development

No branches or pull requests

2 participants