Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add presence indicator online #5513

Conversation

chagai95
Copy link
Contributor

@chagai95 chagai95 commented Mar 11, 2022

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Added presence indicator online like it is done for offline

Motivation and context

Consistency and easier to customise.

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

Signed-off-by: Chagai Friedlander me@chagai.website

@bmarty bmarty added the Z-Community-PR Issue is solved by a community member's PR label Mar 11, 2022
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this new PR.
No problem on the implementation side 👍

Can I ask you to add a file changelog.d/5513.misc with a line explaining the change? It will end up in the main changelog file during the next release.

More details can be found here: https://github.com/vector-im/element-android/blob/main/CONTRIBUTING.md#changelog

@chagai95
Copy link
Contributor Author

chagai95 commented Mar 11, 2022

I could not get gradle to build with the newest from develop, so I couldn't test properly but I have tested on a fork...

@ouchadam ouchadam self-assigned this Mar 15, 2022
changelog.d/5513.misc Outdated Show resolved Hide resolved
@ouchadam
Copy link
Contributor

I've checked out the build locally and had no issues, thanks for the update 💯

Copy link
Contributor

@ouchadam ouchadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a tiny change to the changelog to reflect this is a new attribute

Co-authored-by: Adam Brown <adampsbrown@googlemail.com>
@ouchadam ouchadam changed the base branch from develop to feature/adm/presence-theme-patch March 15, 2022 17:57
@ouchadam ouchadam merged commit c257488 into element-hq:feature/adm/presence-theme-patch Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants