Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update UISI Auto-Reporting to match Web/iOS implementation #5596

Closed
langleyd opened this issue Mar 21, 2022 · 0 comments · Fixed by #5639
Closed

Update UISI Auto-Reporting to match Web/iOS implementation #5596

langleyd opened this issue Mar 21, 2022 · 0 comments · Fixed by #5639
Assignees
@langleyd
Labels
A-E2EE T-Task Refactoring, enabling or disabling functionality, other engineering tasks Z-parity-with-ios
Projects
Issue triage

Comments

@langleyd
Copy link
Contributor

Bring the UISI auto-reporting implementation in line with web and iOS( recently added in element-hq/element-ios#5743)

More Specifically:

  • Implementation of android differed slightly with web in just monitoring decryption attempts after initial sync.
  • Current implementation may be sending false positives as is checking isEncrypted but not clear event/error here
  • Web also allows 60 a minimum of seconds between reports. This is what was also set on iOS and seems like another reasonable measure to avoid user impact and sending to many reports. At the moment on android I think it is 2 seconds.
@langleyd langleyd self-assigned this Mar 21, 2022
@RiotRobot RiotRobot added this to Incoming in Issue triage Mar 21, 2022
@langleyd langleyd mentioned this issue Mar 21, 2022
Merged
3 tasks
@ouchadam ouchadam added A-E2EE T-Task Refactoring, enabling or disabling functionality, other engineering tasks Z-parity-with-ios labels Mar 21, 2022
@ouchadam ouchadam moved this from Incoming to Triaged in Issue triage Mar 21, 2022
@langleyd langleyd mentioned this issue Mar 25, 2022
Merged
Issue triage automation moved this from Triaged to Closed Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@langleyd langleyd

Labels
A-E2EE T-Task Refactoring, enabling or disabling functionality, other engineering tasks Z-parity-with-ios
Projects
No open projects
Issue triage
Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Align Autorageshake with web implementation element-hq/element-android
2 participants
@ouchadam @langleyd