Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sorting of uploads in encrypted rooms #5757

Merged
merged 2 commits into from Apr 14, 2022

Conversation

ofalvai
Copy link
Contributor

@ofalvai ofalvai commented Apr 13, 2022

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Motivation and context

Fixes #2530

There are different loading mechanisms for encrypted and non-encrpyted rooms. The correct sorting was only applied to the non-encrypted codepath, this PR adds sorting to the encrypted codepath too.

Note: this PR won't fix the problem with lazy loading more pages of uploads in the encrypted codepath. I'm new to this codebase and don't see the full implications of that issue, but I'm happy to investigate that further in a separate PR.

Screenshots / GIFs

No screenshots for privacy reasons.

Tests

Open encrypted room with known media history.

Test 1: Open uploads list immediately, without scrolling back up in the timeline to load more media
Test 2: Scroll back in the timeline to cache media, then open uploads list

Tested devices

  • Physical
  • Emulator
  • OS version(s): 11

Checklist

Signed-off-by: Olivér Falvai <ofalvai@gmail.com>
@bmarty bmarty added the Z-Community-PR Issue is solved by a community member's PR label Apr 14, 2022
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me, thanks for your contribution!

@bmarty bmarty enabled auto-merge April 14, 2022 15:35
@bmarty bmarty merged commit 6a6f59a into element-hq:develop Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please use reverse chronological order in Room's Uploads / Media List
2 participants