Adds Suggested Tag in Explore Space #5826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericdecanini
added
PR-Small
ericdecanini
requested review from
niquewoodhouse,
a team and
onurays
and removed request for
a team
|
@ericdecanini can I just check please, are the margins around the items missing or is it just the screenshot being cropped in on the sides? Thanks
|
|
@niquewoodhouse Screenshot cropping indeed. The margins should've been untouched. |
onurays
reviewed
Apr 26, 2022
| @@ -145,6 +145,7 @@ class SpaceDirectoryController @Inject constructor( | |||
| matrixItem(matrixItem) | |||
| avatarRenderer(host.avatarRenderer) | |||
| topic(info.topic) | |||
| suggested(info.suggested ?: false) | |||
There was a problem hiding this comment.
Nit: we generally use info.suggested.orFalse().
Cool thanks, I just wanted to check to make sure! |
niquewoodhouse
approved these changes
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
(Could be feature because it's purely an addition, or could be bugfix because it's techinically a fix for a regression from several versions ago. Considering it a bugfix for that reason)
Content
Adds Suggested Tag in Explore Space (for suggested rooms)
Motivation and context
Closes #5715
Many versions ago (though I am unsure which), we had a suggested tag on each suggested room in the Explore Space screen. This was before the Open and Join buttons were added in the same screen, which is when I assume we lost this suggested tag.
This PR is adding this back in, with a slight design change from what it used to be to accomodate for the new Open and Join buttons.
Screenshots / GIFs
Tests
Tested devices
Checklist