Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signin does not work on server with registration disabled #5874

Closed
c3t4r4 opened this issue Apr 29, 2022 · 20 comments · Fixed by #5928
Closed

Signin does not work on server with registration disabled #5874

c3t4r4 opened this issue Apr 29, 2022 · 20 comments · Fixed by #5928
Assignees
Labels
A-Logout A-Onboarding A-Signin O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@c3t4r4
Copy link

c3t4r4 commented Apr 29, 2022

Steps to reproduce

  1. When you log out and log in again, it doesn't work.
  2. In version 1.4.11 it works normally, from version 1.4.12 and 1.4.13 it doesn't work.

Outcome

Tell the homeserver to log in.

The error appears when informing the homeserver (to login), with an alert that the server does not allow registration

Your phone model

Xiaomi Poco F3

Operating system version

Android 12

Application version and app store

Element Version 1.4.12 and 1.4.13

Homeserver

Sunapse Version 1.57.1

Will you send logs?

No

@c3t4r4 c3t4r4 added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Apr 29, 2022
@RiotRobot RiotRobot added this to Incoming in Issue triage Apr 29, 2022
@illspirit
Copy link

I'm having this issue too.

@eTomte
Copy link

eTomte commented May 1, 2022

This just happened to me as well, although I came by it another way, setting up a new user with an account that I had created manually.

As late as last week I was able to launch Element for the first time, select "Other" for my server, then under "connect to a custom server" I could enter the address for my homeserver, ie., https://matrix.xxxxxxx.org/. at that point it would let me continue to the next screen where I could enter my username and password for that server.

Now, however, when I am on that screen I get an error message stating "Registration has been disabled" when I'm on the "Connect to a custom server" screen.

@5HT2
Copy link

5HT2 commented May 1, 2022

I came here to report this as well. Logs from synapse:

2022-05-01 15:59:26,923 - synapse.access.http.8008 - 427 - INFO - GET-5550 - [REDACTED] - 8008 - {None} Processed request: 0.000sec/0.001sec (0.000sec, 0.000sec) (0.000sec/0.000sec/0) 558B 200 "GET /_matrix/client/versions HTTP/1.1" "Element/1.
4.13 (Linux; U; Android 12; Pixel 4 Build/SP2A.220405.00; Flavour GooglePlay; MatrixAndroidSdk2 1.4.13)" [0 dbevts]
2022-05-01 15:59:26,943 - synapse.access.http.8008 - 427 - INFO - GET-5551 - [REDACTED] - 8008 - {None} Processed request: 0.000sec/0.001sec (0.000sec, 0.000sec) (0.000sec/0.000sec/0) 136B 200 "GET /_matrix/client/r0/login HTTP/1.1" "Element/1.
4.13 (Linux; U; Android 12; Pixel 4 Build/SP2A.220405.00; Flavour GooglePlay; MatrixAndroidSdk2 1.4.13)" [0 dbevts]
2022-05-01 15:59:27,274 - synapse.http.server - 95 - INFO - POST-5552 - <XForwardedForRequest at 0xffff872be7c0 method='POST' uri='/_matrix/client/r0/register' clientproto='HTTP/1.1' site='8008'> SynapseError: 403 - Registration has been disabled
2022-05-01 15:59:27,275 - synapse.access.http.8008 - 427 - INFO - POST-5552 - [REDACTED] - 8008 - {None} Processed request: 0.001sec/0.001sec (0.000sec, 0.000sec) (0.000sec/0.000sec/0) 66B 403 "POST /_matrix/client/r0/register HTTP/1.1" "Elemen
t/1.4.13 (Linux; U; Android 12; Pixel 4 Build/SP2A.220405.00; Flavour GooglePlay; MatrixAndroidSdk2 1.4.13)" [0 dbevts]

This does not happen with the desktop client.

@AshtenThePlatypus
Copy link

Can also confirm. I had to temporarily enable registration to get some people in.

@c3t4r4
Copy link
Author

c3t4r4 commented May 1, 2022

Removing v1.4.13 and installing v1.4.11 manually login works.

@subjugum
Copy link

subjugum commented May 2, 2022

Hi, I was wondering why people had issues with login. Turns out that the option to login is pushed out of view on lower resolution phones. Scrolling down on the selection screen will reveal the new login button. Apparently the other buttons are for registration only now, which is a weird thing to change.

image

@eTomte
Copy link

eTomte commented May 2, 2022

I just tested that, and it isn't correct. If you click "Sign in with Matrix ID" and try to enter a user connected with any other homeserver than matrix.org it will not let you log in.

Instead what you're supposed to do is pick "other" on the screen shot posted, and enter in the address of the homeserver prior to this week doing that would let you progress to another screen where you could then log in. Now it fails with the registration related error. This a bug.

@5HT2
Copy link

5HT2 commented May 2, 2022

Instead what you're supposed to do is pick "other" on the screen shot posted, and enter in the address of the homeserver prior to this week doing that would let you progress to another screen where you could then log in. Now it fails with the registration related error. This a bug.

For what it's worth, the "other" option is what gives me the error when logging in, and "Sign in with Matrix ID" appears to work.

@Nateis1
Copy link

Nateis1 commented May 2, 2022

Hi. I can confirm that we have the same problem : Error message : Registration has been disabled.. Connection fails using the Other option and also with Matrix ID when you try to connect to your homeserver with an already created account. When you uninstall the 1.4.13 release and install back the 1.4.11 one (using apk) you can connect back to your homeserver without any problem. Maybe a Register method launched instead of a Login/SignIn one in the diff code between 1.4.11 an 1.4.12 release.

@0spinboson
Copy link

0spinboson commented May 3, 2022

also affected by this, have no way to log into my home server, as matrix ID option won't work either. Confusing thing is, I don't have registration disabled, just use the registration token option.

@alongls
Copy link
Contributor

alongls commented May 3, 2022

Hello
can confirm that we have the same problem,
downgrading the APP to V1.4.11 solved the issue

@rtest12
Copy link

rtest12 commented May 4, 2022

I'm having this issue too.

@ouchadam ouchadam self-assigned this May 4, 2022
@ouchadam ouchadam added A-Logout A-Signin O-Occasional Affects or can be seen by some users regularly or most users rarely A-Onboarding labels May 4, 2022
@ouchadam
Copy link
Contributor

ouchadam commented May 4, 2022

am able to reproduce the issue on my side, working on a fix.

it's worth noting that sign in with matrix id will work if the homeserver has a .wellknown setup

@ouchadam ouchadam added the S-Major Severely degrades major functionality or product features, with no satisfactory workaround label May 4, 2022
@ouchadam ouchadam moved this from Incoming to Triaged in Issue triage May 4, 2022
Issue triage automation moved this from Triaged to Closed May 4, 2022
@rtest12
Copy link

rtest12 commented May 4, 2022

it's worth noting that sign in with matrix id will work if the homeserver has a .wellknown setup

No, with .wellknown don't work too.

@ouchadam
Copy link
Contributor

ouchadam commented May 4, 2022

Other flow fixed in 1.4.14 with #5928


what's the error you're seeing with sign in with matrix id flow? I'll see if I'm able to reproduce, using my own homeserver I'm able to sign in without issue (with registration disabled)

REGISTRATION DISABLED SIGN IN WITH ID
Screenshot_20220504_132331 after-matrixid-sign-in

https://iswell.cool/.well-known/matrix/client

{"m.homeserver":{"base_url":"https://matrix.iswell.cool"}}

@5HT2
Copy link

5HT2 commented May 4, 2022

it's worth noting that sign in with matrix id will work if the homeserver has a .wellknown setup

Ah, that explains why it was working for me and not other people.

@0spinboson
Copy link

when I tried the matrix ID option it complained about invalid credentials, iirc.

@Toxblh
Copy link

Toxblh commented May 5, 2022

Tested in 1.4.14 Confirm all works as expected via custom server

@ouchadam
Copy link
Contributor

ouchadam commented May 6, 2022

thanks for confirming!

@Nateis1
Copy link

Nateis1 commented May 8, 2022

Hi,
It does work correctly with 1.4.14 now. Thank you for your your help.
Kind Regards,
Mike.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Logout A-Onboarding A-Signin O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
No open projects
Development

Successfully merging a pull request may close this issue.