Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UISIDetector grace period bug #5886

Merged
merged 2 commits into from May 2, 2022

Conversation

BillCarsonFr
Copy link
Member

Type of change

  • Bugfix

Content

Grace period for UISIDetection was not working properly, causing errors to be reported even if the event was decrypted during grace period.

Added Unit test on UISIDetector.

@BillCarsonFr BillCarsonFr force-pushed the feature/bca/fix_graceperiod_autorageshake branch 2 times, most recently from 6073666 to 6741bbb Compare May 2, 2022 07:44
@BillCarsonFr BillCarsonFr requested review from a team, Florian14 and ericdecanini and removed request for a team May 2, 2022 08:09
@BillCarsonFr BillCarsonFr force-pushed the feature/bca/fix_graceperiod_autorageshake branch from 6741bbb to d0bff50 Compare May 2, 2022 08:10
@github-actions
Copy link

github-actions bot commented May 2, 2022

Unit Test Results

122 files  +4  122 suites  +4   2m 15s ⏱️ +57s
205 tests +2  205 ✔️ +2  0 💤 ±0  0 ±0 
690 runs  +8  690 ✔️ +8  0 💤 ±0  0 ±0 

Results for commit f57e20c. ± Comparison against base commit cbc29d0.

♻️ This comment has been updated with latest results.

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update.

Copy link
Contributor

@Florian14 Florian14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BillCarsonFr BillCarsonFr merged commit 2da109c into develop May 2, 2022
@BillCarsonFr BillCarsonFr deleted the feature/bca/fix_graceperiod_autorageshake branch May 2, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants