Upgrade Jitsi SDK to 6.2.2 #6195

bmarty · 2022-05-30T19:45:25Z

Type of change

Feature
Bugfix
Technical
Other : lib upgrade

Content

Upgrade Jitsi to 6.2.2.
As a bonus, I have added a debug activity to display some info about Jitsi. I did not find a way to retrieve the version and both button does nothing. I keep it though, could be useful for future tests.

This upgrade should also fix this warning from the PlayStore:

(https://support.google.com/faqs/answer/12577537)

Demo of the new version:

new pre-launch screen
new Foreground service

Motivation and context

Closes #5745

Screenshots / GIFs

Tests

Crash is confirmed fixed.

But I have issue when trying to answer/reject a WebRTC call. Still investigating if it's new or not :/
EDIT: everything is working fine today.

Tested devices

Physical
Emulator
OS version(s):

Checklist

Changes has been tested on an Android device or Android emulator with API 21
UI change has been tested on both light and dark themes
Accessibility has been taken into account. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
Pull request is based on the develop branch
Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
Pull request includes screenshots or videos if containing UI changes
Pull request includes a sign off
You've made a self review of your PR
If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

github-actions · 2022-05-30T20:20:19Z

Unit Test Results

146 files +  4 146 suites +4 2m 46s ⏱️ +16s
236 tests +  7 236 ✔️ +  7 0 💤 ±0 0 ❌ ±0
788 runs +28 788 ✔️ +28 0 💤 ±0 0 ❌ ±0

Results for commit dc5e9f4. ± Comparison against base commit 483b1ab.

♻️ This comment has been updated with latest results.

dependencies_groups.gradle

ganfra

One question otherwise LGTM

yostyle

LGTM

bmarty · 2022-06-07T20:38:23Z

To be updated, exodus is detecting a new tracker "GIPHY Analytics":

sonarcloud · 2022-06-29T08:50:16Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

bmarty · 2022-06-30T20:32:08Z

Decision has been taken today to wait for Jitsi to provide a version without a tracker. So wait for jitsi/jitsi-meet#11759 to be fixed and released.

bmarty · 2022-07-21T13:35:33Z

According to jitsi/jitsi-meet#11759 (comment) it seems that this could be unblocked.

bmarty · 2022-10-25T13:57:42Z

Updating to 6.2.2, but the code is not compiling yet.

Error was lots of `Duplicate class org.checkerframework.common.reflection.qual.MethodVal found in modules jetified-checker-3.1 (org.checkerframework:checker:3.1.1) and jetified-checker-qual-3.12.0 (org.checkerframework:checker-qual:3.12.0) Cannot use latest 3.15.0 since it required min API 26.

…yet.

ElementBot · 2022-10-27T14:29:12Z

	Warnings
⚠️	vector/src/main/AndroidManifest.xml#L200 - Consider splitting data tag into multiple tags with individual attributes to avoid confusion
⚠️	vector/src/main/AndroidManifest.xml#L200 - Consider splitting data tag into multiple tags with individual attributes to avoid confusion
⚠️	vector/src/main/AndroidManifest.xml#L203 - Consider splitting data tag into multiple tags with individual attributes to avoid confusion
⚠️	vector/src/main/AndroidManifest.xml#L203 - Consider splitting data tag into multiple tags with individual attributes to avoid confusion
⚠️	vector/src/main/AndroidManifest.xml#L257 - Expecting `android:screenOrientation="unspecified"` or `"fullSensor"` for this activity so the user can use the application in any orientation and provide a great experience on Chrome OS devices
⚠️	vector/src/main/AndroidManifest.xml#L257 - Expecting `android:screenOrientation="unspecified"` or `"fullSensor"` for this activity so the user can use the application in any orientation and provide a great experience on Chrome OS devices
⚠️	vector/src/main/AndroidManifest.xml#L266 - Attribute `supportsPictureInPicture` is only used in API level 24 and higher (current min is 21)
⚠️	vector/src/main/AndroidManifest.xml#L266 - Attribute `supportsPictureInPicture` is only used in API level 24 and higher (current min is 21)
⚠️	vector/src/main/AndroidManifest.xml#L273 - Attribute `supportsPictureInPicture` is only used in API level 24 and higher (current min is 21)
⚠️	vector/src/main/AndroidManifest.xml#L273 - Attribute `supportsPictureInPicture` is only used in API level 24 and higher (current min is 21)
⚠️	vector/src/main/AndroidManifest.xml#L279 - Attribute `supportsPictureInPicture` is only used in API level 24 and higher (current min is 21)
⚠️	vector/src/main/AndroidManifest.xml#L279 - Attribute `supportsPictureInPicture` is only used in API level 24 and higher (current min is 21)
⚠️	vector/src/main/AndroidManifest.xml#L399 - Exported receiver does not require permission
⚠️	vector/src/main/AndroidManifest.xml#L399 - Exported receiver does not require permission

Generated by 🚫 dangerJS against fbabe50

Thread: main, Exception: java.lang.RuntimeException: Unable to start service org.jitsi.meet.sdk.JitsiMeetOngoingConferenceService@3d1f0bc with Intent { cmp=im.vector.app.debug/org.jitsi.meet.sdk.JitsiMeetOngoingConferenceService (has extras) }: java.lang.IllegalArgumentException: Invalid notification (no valid small icon): Notification(channel=JitsiOngoingConferenceChannel pri=0 contentView=null vibrate=null sound=null defaults=0x0 flags=0xa color=0x00000000 category=call actions=2 vis=PUBLIC semFlags=0x0 semPriority=0 semMissedCount=0)

sonarcloud · 2022-10-28T17:03:36Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

0.0% Coverage
0.0% Duplication

manuroe added this to In progress in Android App Team May 31, 2022

manuroe removed this from In progress in Android App Team May 31, 2022

bmarty marked this pull request as ready for review May 31, 2022 12:38

bmarty requested review from a team, yostyle and ganfra and removed request for a team May 31, 2022 12:38

ganfra reviewed Jun 1, 2022

View reviewed changes

dependencies_groups.gradle Outdated Show resolved Hide resolved

ganfra approved these changes Jun 1, 2022

View reviewed changes

yostyle approved these changes Jun 7, 2022

View reviewed changes

bmarty changed the title ~~Feature/bma/jitsi 5 1 0~~ Feature/bma/jitsi 5 1 0 - BLOCKED BY EXODUS Jun 16, 2022

This was referenced Jun 28, 2022

Viewing Jitsi participant crashes the app #5745

Closed

[Android SDK][5.1.0] Trackers GIPHY Analytics and IAB Open measurement jitsi/jitsi-meet#11759

Closed

bmarty force-pushed the feature/bma/jitsi_5_1_0 branch from dc5e9f4 to b3fdd64 Compare June 29, 2022 07:39

bmarty force-pushed the feature/bma/jitsi_5_1_0 branch from b3fdd64 to cf9135c Compare October 25, 2022 10:18

bmarty changed the title ~~Feature/bma/jitsi 5 1 0 - BLOCKED BY EXODUS~~ Upgrade Jitsi SDK to 6.2.2 Oct 25, 2022

bmarty mentioned this pull request Oct 25, 2022

[Android SDK][6.2.2] Upgrading to SDK 6.2.2 lead to compilation error jitsi/jitsi-meet#12456

Closed

bmarty added 7 commits October 27, 2022 14:33

Build android-sdk-6.2.2

77f7b41

Update the recipe.

a1278ee

Update Jitsi and WebRtc dependencies to android-sdk-6.2.2

4515dcd

Add a DebugJitsiActivity for debug build only. It's quite useless...

16a5046

changelog

461d07a

Improve comment

acd02d1

Fix lint issue

ac4785a

bmarty and others added 3 commits October 27, 2022 14:36

API break, replace leave() by broadcast

1b5852f

Fix issue with Back button not working when conference is not joined …

6b34bb2

…yet.

bmarty force-pushed the feature/bma/jitsi_5_1_0 branch from 49221c6 to 51ed51e Compare October 27, 2022 14:26

bmarty requested a review from ganfra October 27, 2022 14:35

bmarty added the Z-NextRelease For issues and PRs which should be included in the NextRelease. label Oct 27, 2022

bmarty force-pushed the feature/bma/jitsi_5_1_0 branch from 51ed51e to 46d1795 Compare October 28, 2022 14:06

Fix vulnerability

fbabe50

ganfra approved these changes Nov 2, 2022

View reviewed changes

ganfra merged commit d954c9e into develop Nov 2, 2022

ganfra deleted the feature/bma/jitsi_5_1_0 branch November 2, 2022 11:10

Juha-Park-TII-SSRC mentioned this pull request Feb 15, 2023

can not make video calls #7619

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade Jitsi SDK to 6.2.2 #6195

Upgrade Jitsi SDK to 6.2.2 #6195

bmarty commented May 30, 2022 •

edited

github-actions bot commented May 30, 2022 •

edited

ganfra left a comment

yostyle left a comment

bmarty commented Jun 7, 2022

sonarcloud bot commented Jun 29, 2022

bmarty commented Jun 30, 2022

bmarty commented Jul 21, 2022

bmarty commented Oct 25, 2022

ElementBot commented Oct 27, 2022 •

edited

sonarcloud bot commented Oct 28, 2022

Upgrade Jitsi SDK to 6.2.2 #6195

Upgrade Jitsi SDK to 6.2.2 #6195

Conversation

bmarty commented May 30, 2022 • edited

Type of change

Content

Motivation and context

Screenshots / GIFs

Tests

Tested devices

Checklist

github-actions bot commented May 30, 2022 • edited

Unit Test Results

ganfra left a comment

Choose a reason for hiding this comment

yostyle left a comment

Choose a reason for hiding this comment

bmarty commented Jun 7, 2022

sonarcloud bot commented Jun 29, 2022

bmarty commented Jun 30, 2022

bmarty commented Jul 21, 2022

bmarty commented Oct 25, 2022

ElementBot commented Oct 27, 2022 • edited

sonarcloud bot commented Oct 28, 2022

bmarty commented May 30, 2022 •

edited

github-actions bot commented May 30, 2022 •

edited

ElementBot commented Oct 27, 2022 •

edited