Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of ffmpeg-kit #6203

Closed
jmartinesp opened this issue May 31, 2022 · 2 comments · Fixed by #6208
Closed

Remove usage of ffmpeg-kit #6203

jmartinesp opened this issue May 31, 2022 · 2 comments · Fixed by #6208
Assignees
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@jmartinesp
Copy link
Contributor

Your use case

What would you like to do?

Remove all usages of the ffmpeg-kit library.

Why would you like to do it?

Currently we use ffmpeg-kit to transcode voice recording to and from ogg files with opus codec on Android versions < 10. This is a bit of an overkill, and it's also a problem for some of our customers. It should also save us a few MBs on app size.

How would you like to achieve it?

We can remove ffmpeg-kit and use libopus and libopusenc instead.

Have you considered any alternatives?

Yes, I tried several replacement libraries but in the end the simpler solution was to use the native libs for transcoding.

Additional context

No response

@jmartinesp jmartinesp added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label May 31, 2022
@jmartinesp jmartinesp self-assigned this May 31, 2022
@bmarty
Copy link
Member

bmarty commented May 31, 2022

Please double check that the license (https://github.com/xiph/libopusenc/blob/master/COPYING) is fine for our usage.

@jmartinesp
Copy link
Contributor Author

Please double check that the license (https://github.com/xiph/libopusenc/blob/master/COPYING) is fine for our usage.

It's BSD so it shouldn't be a problem.

@RiotRobot RiotRobot added this to Incoming in Issue triage May 31, 2022
@ouchadam ouchadam moved this from Incoming to Triaged in Issue triage Jun 13, 2022
Issue triage automation moved this from Triaged to Closed Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants