Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the PR process doc to come back to one reviewer #6396

Merged
merged 1 commit into from Jun 28, 2022
Merged

Update the PR process doc to come back to one reviewer #6396

merged 1 commit into from Jun 28, 2022

Conversation

manuroe
Copy link
Member

@manuroe manuroe commented Jun 28, 2022

with optional additional reviewers

@manuroe manuroe force-pushed the feature/manu/pr-optional-2nd-review branch from f49dcca to 1e2e086 Compare June 28, 2022 10:28
@manuroe manuroe force-pushed the feature/manu/pr-optional-2nd-review branch from 1e2e086 to 65b634f Compare June 28, 2022 10:32
@manuroe manuroe requested a review from bmarty June 28, 2022 10:33
@manuroe manuroe marked this pull request as ready for review June 28, 2022 10:33
@sonarcloud
Copy link

sonarcloud bot commented Jun 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

bmarty
bmarty approved these changes Jun 28, 2022
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bmarty bmarty merged commit c50c9b9 into develop Jun 28, 2022
@bmarty bmarty deleted the feature/manu/pr-optional-2nd-review branch June 28, 2022 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ouchadam ouchadam ouchadam approved these changes

@bmarty bmarty bmarty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@manuroe @ouchadam @bmarty