Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid direct BuildConfig usages #6406

Closed
ouchadam opened this issue Jun 28, 2022 · 0 comments · Fixed by #6517
Closed

Avoid direct BuildConfig usages #6406

ouchadam opened this issue Jun 28, 2022 · 0 comments · Fixed by #6517
Assignees
Labels
A-DevX Anything that can improve the DevX T-Task Refactoring, enabling or disabling functionality, other engineering tasks Z-ElementX Z-Modularization

Comments

@ouchadam
Copy link
Contributor

In order to migrate to a modular world we'll need to avoid directly using the BuildConfig as we'll want to have a single entry point rather than multiple build files with their own configuration.

The abstraction should be injectable via the dagger graph and provided by the main Android Application module

@ouchadam ouchadam added T-Task Refactoring, enabling or disabling functionality, other engineering tasks A-DevX Anything that can improve the DevX labels Jun 28, 2022
@RiotRobot RiotRobot added this to Incoming in Issue triage Jun 28, 2022
@ouchadam ouchadam moved this from Incoming to Triaged in Issue triage Jun 28, 2022
@ouchadam ouchadam self-assigned this Jul 1, 2022
Issue triage automation moved this from Triaged to Closed Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-DevX Anything that can improve the DevX T-Task Refactoring, enabling or disabling functionality, other engineering tasks Z-ElementX Z-Modularization
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants