Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gallery picker can pick external images (not just videos) #6450

Merged
merged 1 commit into from Jul 4, 2022

Conversation

cloudrac3r
Copy link
Contributor

Type of change

  • Bugfix

Content

Gallery picker can now pick external images. Previously, choosing an external application would only allow videos, not images. This was due to one of the mime type entries being interpreted incorrectly.

The scenarios for attaching files are as follows:

Attach file

For comparison.

  • "Recent" screen displays other file types and filters
  • External gallery displays all image/video files
  • External file manager displays all files

Attach gallery (old)

  • "Recent" screen only displays image/video files and filters - right
  • External gallery only displays video files - wrong
  • External file manager displays all files - technically wrong but not a problem

Attach gallery (new)

  • "Recent" screen only displays image/video files and filters - right
  • External gallery displays all image/video files - right
  • External file manger displays all files - technically wrong but not a problem

Motivation and context

#5507

Tested devices

  • Physical, LineageOS 18.1 (Android 11)

Checklist

  • Changes has been tested on an Android device or Android emulator with API 21
  • N/A - UI change has been tested on both light and dark themes
  • N/A - Accessibility has been taken into account.
  • Pull request is based on the develop branch
  • Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
  • N/A - Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR
  • N/A - If you have modified the screen flow, or added new screens to the application

Signed-off-by: Cadence Ember cloudrac3r@vivaldi.net

@bmarty bmarty self-requested a review July 4, 2022 07:43
@bmarty bmarty added the Z-Community-PR Issue is solved by a community member's PR label Jul 4, 2022
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bmarty bmarty merged commit cadd5c0 into element-hq:develop Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants