Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Location Share] - Expanded map state when no more live location shares #6635

Closed
mnaturel opened this issue Jul 25, 2022 · 0 comments · Fixed by #6636
Closed

[Location Share] - Expanded map state when no more live location shares #6635

mnaturel opened this issue Jul 25, 2022 · 0 comments · Fixed by #6636
Assignees
@mnaturel
Labels
A-Location T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
Issue triage

Comments

@mnaturel
Copy link
Contributor

Your use case

What would you like to do?

When I am in the expanded map view and all user’s live-shares have ended:

  • The pin disappears but the map remains at the position and zoom level that I had it
  • I can still interact with the map.
  • The share icon at the top-right is removed
  • The bottom tray shows a greyed-out share icon and ‘live location ended’.
  • This is only available if I am in the expanded map-view at the moment that the share ends. I cannot re-enter this view by clicking on the tile for a stopped live-share.

Why would you like to do it?

To improve UX.

How would you like to achieve it?

See https://www.figma.com/file/uthEK6xuo9hSQRdWvPAre5/Location-Sharing?node-id=402%3A50710

Have you considered any alternatives?

No response

Additional context

No response

Are you willing to provide a PR?

Yes
@mnaturel mnaturel added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements A-Location labels Jul 25, 2022
@mnaturel mnaturel self-assigned this Jul 25, 2022
@RiotRobot RiotRobot added this to Incoming in Issue triage Jul 25, 2022
@mnaturel mnaturel moved this from Incoming to Triaged in Issue triage Jul 25, 2022
@mnaturel mnaturel mentioned this issue Jul 25, 2022
Merged
15 tasks
Issue triage automation moved this from Triaged to Closed Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnaturel mnaturel

Labels
A-Location T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
No open projects
Issue triage
Closed
Milestone
No milestone
1 participant
@mnaturel