Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ObjectAnimators are not canceled in TypingMessageDotsView #6663

Closed
mnaturel opened this issue Jul 28, 2022 · 0 comments · Fixed by #6664
Closed

ObjectAnimators are not canceled in TypingMessageDotsView #6663

mnaturel opened this issue Jul 28, 2022 · 0 comments · Fixed by #6664
Assignees
@mnaturel
Labels
T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
Issue triage

Comments

@mnaturel
Copy link
Contributor

mnaturel commented Jul 28, 2022 •
edited

Description

To cancel infinite animations launched in TypingMessageDotsView, we use clearAnimation(). Unfortunately there is a weakreference between the animation object and the View, meaning it will not cancel the infinite animations which will run forever.
More explanation here: https://issuetracker.google.com/issues/212993949

It may lead to slowness in timeline as the app is being used without restart.

Outcome

What did you expect?

Infinite object animators should be canceled when the View is destroyed.

What happened instead?

Infinite object animators are not canceled.

Your phone model

No response

Operating system version

No response

Application version and app store

No response

Homeserver

No response

Will you send logs?

No

Are you willing to provide a PR?

Yes
@mnaturel mnaturel added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Jul 28, 2022
@mnaturel mnaturel self-assigned this Jul 28, 2022
@RiotRobot RiotRobot added this to Incoming in Issue triage Jul 28, 2022
@mnaturel mnaturel moved this from Incoming to Triaged in Issue triage Jul 28, 2022
@mnaturel mnaturel mentioned this issue Jul 28, 2022
Merged
15 tasks
Issue triage automation moved this from Triaged to Closed Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnaturel mnaturel

Labels
T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
No open projects
Issue triage
Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cancel infinite animations in TypingMessageDotsView element-hq/element-android
1 participant
@mnaturel