Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Location Share] Render fallback UI when map fails to load #6711

Closed
mnaturel opened this issue Aug 1, 2022 · 0 comments · Fixed by #6712
Closed

[Location Share] Render fallback UI when map fails to load #6711

mnaturel opened this issue Aug 1, 2022 · 0 comments · Fixed by #6712
Assignees
@mnaturel
Labels
A-Location T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
Issue triage

Comments

@mnaturel
Copy link
Contributor

mnaturel commented Aug 1, 2022 •
edited

Your use case

What would you like to do?

Show a specific error when map fails to load.

Why would you like to do it?

In some cases (e.g. the home server is not configured well for map style url), the maps may fail to load.

How would you like to achieve it?

Add a listener on map loading error.
For UI, see https://www.figma.com/file/uthEK6xuo9hSQRdWvPAre5/Location-Sharing?node-id=2302%3A64561

Have you considered any alternatives?

No response

Additional context

No response

Are you willing to provide a PR?

Yes
@mnaturel mnaturel added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements A-Location labels Aug 1, 2022
@mnaturel mnaturel self-assigned this Aug 1, 2022
@RiotRobot RiotRobot added this to Incoming in Issue triage Aug 1, 2022
@mnaturel mnaturel moved this from Incoming to Triaged in Issue triage Aug 1, 2022
@mnaturel mnaturel mentioned this issue Aug 1, 2022
Merged
15 tasks
Issue triage automation moved this from Triaged to Closed Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnaturel mnaturel

Labels
A-Location T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
No open projects
Issue triage
Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Location Share] Render fallback UI when map fails to load (PSG-607) element-hq/element-android
1 participant
@mnaturel