Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easier to find developer sign-off instructions #6739

Merged
merged 2 commits into from Aug 4, 2022

Conversation

michaelkaye
Copy link
Contributor

@michaelkaye michaelkaye commented Aug 4, 2022

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other : update dangerfile

Content

Add link to synapse docs on how to provide DCO (which are linked elsewhere in the project) to the dangerfile message.

Motivation and context

Make it easier for third parties to contribute by making it more obvious how to sign off (and that it's not a lengthy Process).

Screenshots / GIFs

dco_request

Tests

This PR did not have a DCO signoff.

Checklist

Signed-off-by: Michael Kaye 1917473+michaelkaye@users.noreply.github.com

@michaelkaye michaelkaye marked this pull request as ready for review August 4, 2022 12:29
@michaelkaye michaelkaye changed the title Make it easier to find sign-off instructions Make it easier to find developer sign-off instructions Aug 4, 2022
@michaelkaye
Copy link
Contributor Author

The danger failure is an old failure that has been corrected.
the lint failure is an OOM that is being addressed elsewhere - think we're good to force merge this?

@ouchadam
Copy link
Contributor

ouchadam commented Aug 4, 2022

@michaelkaye yep! the lint issue should be fixed with #6728 (just merged)

@michaelkaye michaelkaye merged commit 09a91c4 into develop Aug 4, 2022
@michaelkaye michaelkaye deleted the misc/michaelk/danger_link_to_DCO_signoff branch August 4, 2022 14:54
@sonarcloud
Copy link

sonarcloud bot commented Aug 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants