Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a developer setting to enable LeakCanary at runtime #6786

Closed
mnaturel opened this issue Aug 9, 2022 · 0 comments · Fixed by #6792
Closed

Add a developer setting to enable LeakCanary at runtime #6786

mnaturel opened this issue Aug 9, 2022 · 0 comments · Fixed by #6792
Assignees
@mnaturel
Labels
A-DevX Anything that can improve the DevX T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
Issue triage

Comments

@mnaturel
Copy link
Contributor

mnaturel commented Aug 9, 2022

Your use case

What would you like to do?

Introduce a new developer setting only visible in debug variant to be able to enable LeakCanary at runtime.

Why would you like to do it?

To perform memory leak analysis of the app on demand. We should be able to disable it as the analysis has an impact on the app performances.

How would you like to achieve it?

https://square.github.io/leakcanary/recipes/#disabling-leakcanary

Have you considered any alternatives?

No response

Additional context

No response

Are you willing to provide a PR?

Yes
@mnaturel mnaturel added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements A-DevX Anything that can improve the DevX labels Aug 9, 2022
@mnaturel mnaturel self-assigned this Aug 9, 2022
@RiotRobot RiotRobot added this to Incoming in Issue triage Aug 9, 2022
@mnaturel mnaturel moved this from Incoming to Triaged in Issue triage Aug 9, 2022
@mnaturel mnaturel mentioned this issue Aug 9, 2022
Merged
15 tasks
Issue triage automation moved this from Triaged to Closed Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnaturel mnaturel

Labels
A-DevX Anything that can improve the DevX T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
No open projects
Issue triage
Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a developer setting to enable LeakCanary at runtime element-hq/element-android
1 participant
@mnaturel