Reduce boilerplate with some minor sdk improvements

[Florian14]

Type of change

• Feature
• Bugfix
• Technical
• Other :

Content

Improve some sdk stuff:

• Provide JSON keys inside enum fields as a value for GuestAccess and RoomHistoryVisibility (It is already the case for some existing enums) -> It limits the duplication of the keys by having them in a single place
• Replace manual mapping with the related Content models in CreateRoomBodyBuilder -> it removes some JSON keys duplication and adds clarity to the code
• Replace the return type of RoomFeaturePreset.setupInitialStates from a List<Event> to a List<CreateRoomStateEvent> to be consistent with CreateRoomParams.initialStates

Motivation and context

Further developments related to #5525

Tests

By creating rooms in order to trigger the modified code, adding breakpoints and checking that the code was correctly executed.

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• Changes has been tested on an Android device or Android emulator with API 21
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR
• If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

[Florian14]

Not sure about the changelog description, maybe I should have split the PR?

[ericdecanini]

I don't see anything wrong. It makes perfect sense to me

[ericdecanini]

Nice cleanup! It can also be further simplified by adding a companion object function in RoomHistoryVisibility

    companion object {
        fun where(value: String) = values().find { it.value == value }
    }

Consider it optional

[Florian14]

Nice cleanup! It can also be further simplified by adding a companion object function in RoomHistoryVisibility

    companion object {
        fun where(value: String) = values().find { it.value == value }
    }

Consider it optional

I like your proposal, I will probably do it in a new PR in a more general way!

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

81.6% Coverage
0.0% Duplication