Space response model #7035
Merged
Space response model #7035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`rooms.children_state` is now a list of `SpaceChildSummaryEvent` instead of a list of `Event`.
bmarty
commented
Sep 6, 2022
| @Json(name = "content") val content: Content? = null, | ||
| @Json(name = "sender") val senderId: String? = null, | ||
| @Json(name = "origin_server_ts") val originServerTs: Long? = null, | ||
| ) |
There was a problem hiding this comment.
Only fields declared in this object will be accessible to the SDK and the app.
|
SonarCloud Quality Gate failed. |
ericdecanini
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Ensure that we do not expect Event field that won't be returned by the server by creating a dedicated Json model.
Assigning to Eric who made some change on this area.
Motivation and context
Avoid future mistake of using field that are not provided in the server response.
The current implementation does not use
Event.roomId, but with this change, we ensure that it's not the case (and it will not be the case in the future.See matrix-org/synapse#13506
Screenshots / GIFs
NA
Tests
The code is compiling, there is not behavior nor UI change.
Tested devices
None.
Checklist