Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: only run sonarqube task when token is known #7057

Closed
mnaturel opened this issue Sep 7, 2022 · 0 comments · Fixed by #7058
Closed

CI: only run sonarqube task when token is known #7057

mnaturel opened this issue Sep 7, 2022 · 0 comments · Fixed by #7058
Assignees
@mnaturel
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements z-CI
Projects
Issue triage

Comments

@mnaturel
Copy link
Contributor

mnaturel commented Sep 7, 2022

Your use case

What would you like to do?

Update the Github workflow to run sonarqube task only when the token is known.

Why would you like to do it?

Some PR like the ones from dependabot do not pass due to missing tokens.

How would you like to achieve it?

Add a condition on the token content to run the sonar step.

Have you considered any alternatives?

No response

Additional context

No response

Are you willing to provide a PR?

Yes
@mnaturel mnaturel added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements z-CI labels Sep 7, 2022
@mnaturel mnaturel self-assigned this Sep 7, 2022
@RiotRobot RiotRobot added this to Incoming in Issue triage Sep 7, 2022
@mnaturel mnaturel mentioned this issue Sep 7, 2022
Merged
15 tasks
@mnaturel mnaturel moved this from Incoming to Triaged in Issue triage Sep 7, 2022
Issue triage automation moved this from Triaged to Closed Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnaturel mnaturel

Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements z-CI
Projects
No open projects
Issue triage
Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CI: only run sonarqube task when token is known element-hq/element-android
1 participant
@mnaturel