Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voice Broadcast - Add a feature flag with the composer action #7258

Merged
merged 3 commits into from Oct 4, 2022

Conversation

Florian14
Copy link
Contributor

@Florian14 Florian14 commented Sep 29, 2022

Type of change

  • WIP Feature
  • Bugfix
  • Technical
  • Other :

Content

  • Add a debug feature flag to enable the voice broadcast feature
  • Add the composer action to start a voice broadcast according to the feature flag (only show a log for the moment)

Note: added a todo for the permission check which will be added in a dedicated PR about voice broadcast permissions

Motivation and context

#7127

Screenshots / GIFs

Feature flag Composer action
Screenshot_1664461636 Screenshot_1664461526

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@Florian14 Florian14 marked this pull request as ready for review September 29, 2022 14:33
@Florian14 Florian14 requested review from a team and bmarty and removed request for a team September 29, 2022 14:33
@Florian14 Florian14 changed the title Voice Broadcast - Add feature flag with composer action Voice Broadcast - Add a feature flag with the composer action Sep 29, 2022
@Florian14 Florian14 force-pushed the feature/fre/voice_broadcast_feature_flag branch from b98d968 to 2812b16 Compare October 3, 2022 07:26
@ElementBot
Copy link

Warnings
⚠️

vector/src/main/java/im/vector/app/features/attachments/AttachmentTypeSelectorView.kt#L70 - Avoid passing null as the view root (needed to resolve layout parameters on the inflated layout's root element)

⚠️

vector/src/main/java/im/vector/app/features/attachments/AttachmentTypeSelectorView.kt#L70 - Avoid passing null as the view root (needed to resolve layout parameters on the inflated layout's root element)

⚠️

vector/src/main/java/im/vector/app/features/attachments/AttachmentTypeSelectorView.kt#L70 - Avoid passing null as the view root (needed to resolve layout parameters on the inflated layout's root element)

⚠️

vector/src/main/java/im/vector/app/features/attachments/AttachmentTypeSelectorView.kt#L70 - Avoid passing null as the view root (needed to resolve layout parameters on the inflated layout's root element)

⚠️

vector/src/main/res/drawable/ic_attachment_voice_broadcast.xml#L7 - Very long vector path (1102 characters), which is bad for performance. Considering reducing precision, removing minor details or rasterizing vector.

⚠️

vector/src/main/res/drawable/ic_attachment_voice_broadcast.xml#L7 - Very long vector path (1102 characters), which is bad for performance. Considering reducing precision, removing minor details or rasterizing vector.

⚠️

vector/src/main/res/drawable/ic_attachment_voice_broadcast.xml#L10 - Very long vector path (1022 characters), which is bad for performance. Considering reducing precision, removing minor details or rasterizing vector.

⚠️

vector/src/main/res/drawable/ic_attachment_voice_broadcast.xml#L10 - Very long vector path (1022 characters), which is bad for performance. Considering reducing precision, removing minor details or rasterizing vector.

⚠️

vector/src/main/res/drawable/ic_attachment_voice_broadcast.xml#L13 - Very long vector path (989 characters), which is bad for performance. Considering reducing precision, removing minor details or rasterizing vector.

⚠️

vector/src/main/res/drawable/ic_attachment_voice_broadcast.xml#L13 - Very long vector path (989 characters), which is bad for performance. Considering reducing precision, removing minor details or rasterizing vector.

⚠️

vector/src/main/res/drawable/ic_attachment_voice_broadcast.xml#L16 - Very long vector path (961 characters), which is bad for performance. Considering reducing precision, removing minor details or rasterizing vector.

⚠️

vector/src/main/res/drawable/ic_attachment_voice_broadcast.xml#L16 - Very long vector path (961 characters), which is bad for performance. Considering reducing precision, removing minor details or rasterizing vector.

⚠️

vector/src/main/res/layout/view_attachment_type_selector.xml#L7 - Possible overdraw: Root element paints background ?android:colorBackground with a theme that also paints a background (inferred theme is @android:style/Theme.Holo)

⚠️

vector/src/main/res/layout/view_attachment_type_selector.xml#L7 - Possible overdraw: Root element paints background ?android:colorBackground with a theme that also paints a background (inferred theme is @android:style/Theme.Holo)

Generated by 🚫 dangerJS against 2812b16

@sonarcloud
Copy link

sonarcloud bot commented Oct 3, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

10.0% 10.0% Coverage
0.0% 0.0% Duplication

Copy link
Member

@giomfo giomfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM,
I approved it as a first reviewer. @bmarty I let you review it for a final review

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks.

only show a toast for the moment

I think there is only a log for now. But this is fine :)

The tooltip is something else.

@Florian14 Florian14 merged commit 8e3b973 into develop Oct 4, 2022
@Florian14 Florian14 deleted the feature/fre/voice_broadcast_feature_flag branch October 4, 2022 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants