Replace org.apache.sanselan:sanselan by org.apache.commons:commons-imaging #7454

bmarty · 2022-10-26T10:39:57Z

Type of change

Feature
Bugfix
Technical
Other :

Content

Replace outdated dependency. Not sure why sanselan was used at the beginning.

Motivation and context

Fixes #7453

Screenshots / GIFs

Tests

Send an image with GPS data, without compressing
Check that the sent image does not contains GPS data

Available info after sending (so visible by everyone in the room):

We could strip more data, but this is maybe out of scope of this PR.

Tested devices

Physical
Emulator
OS version(s):

Checklist

Changes has been tested on an Android device or Android emulator with API 21
UI change has been tested on both light and dark themes
Accessibility has been taken into account. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
Pull request is based on the develop branch
Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
Pull request includes screenshots or videos if containing UI changes
Pull request includes a sign off
You've made a self review of your PR
If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

…rg.apache.commons:commons-imaging:1.0-alpha3`

bmarty · 2022-10-26T10:56:53Z

...android/src/main/java/org/matrix/android/sdk/internal/session/content/ImageExifTagRemover.kt

@@ -82,4 +71,12 @@ internal class ImageExifTagRemover @Inject constructor(
                }
        )
    }
+
+    private val tagsToRemove
+        get() = GpsTagConstants.ALL_GPS_TAGS +


FTR, this is defined by

public static final List<TagInfo> ALL_GPS_TAGS = Collections.unmodifiableList(Arrays.asList( GPS_TAG_GPS_VERSION_ID, GPS_TAG_GPS_LATITUDE_REF, GPS_TAG_GPS_LATITUDE, GPS_TAG_GPS_LONGITUDE_REF, GPS_TAG_GPS_LONGITUDE, GPS_TAG_GPS_ALTITUDE_REF, GPS_TAG_GPS_ALTITUDE, GPS_TAG_GPS_TIME_STAMP, GPS_TAG_GPS_SATELLITES, GPS_TAG_GPS_STATUS, GPS_TAG_GPS_MEASURE_MODE, GPS_TAG_GPS_DOP, GPS_TAG_GPS_SPEED_REF, GPS_TAG_GPS_SPEED, GPS_TAG_GPS_TRACK_REF, GPS_TAG_GPS_TRACK, GPS_TAG_GPS_IMG_DIRECTION_REF, GPS_TAG_GPS_IMG_DIRECTION, GPS_TAG_GPS_MAP_DATUM, GPS_TAG_GPS_DEST_LATITUDE_REF, GPS_TAG_GPS_DEST_LATITUDE, GPS_TAG_GPS_DEST_LONGITUDE_REF, GPS_TAG_GPS_DEST_LONGITUDE, GPS_TAG_GPS_DEST_BEARING_REF, GPS_TAG_GPS_DEST_BEARING, GPS_TAG_GPS_DEST_DISTANCE_REF, GPS_TAG_GPS_DEST_DISTANCE, GPS_TAG_GPS_PROCESSING_METHOD, GPS_TAG_GPS_AREA_INFORMATION, GPS_TAG_GPS_DATE_STAMP, GPS_TAG_GPS_DIFFERENTIAL));