Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist the playback state of voice messages across different screens #7582

Merged
merged 2 commits into from Nov 15, 2022

Conversation

Florian14
Copy link
Contributor

@Florian14 Florian14 commented Nov 14, 2022

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

When pausing a voice message playback, the playback position is now persisted when closing the room timeline.
This also affects voice broadcast playbacks.

Motivation and context

Voice Broadcast feature requires to be able to listen to a voice broadcast when navigating across the app. For this need, we decided to not reset the playback position for voice messages when closing the room timeline.

The positions will be reset only after killing the application.

Screenshots / GIFs

Tests

  • Have a room timeline with several voice broadcasts and voice messages
  • Play/pause some of them or seek to a given position
  • Navigate into the app
  • Go back to the previous room
  • Verify that the playback positions are not reset
  • Verify that the position is correct when resuming the playback

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@Florian14 Florian14 requested review from a team and ganfra and removed request for a team November 14, 2022 14:20
@Florian14 Florian14 added the PR-Small PR with less than 20 updated lines label Nov 14, 2022
@Florian14 Florian14 changed the base branch from develop to feature/fre/voice_broadcast_live_indicator November 14, 2022 19:31
@Florian14 Florian14 changed the base branch from feature/fre/voice_broadcast_live_indicator to develop November 14, 2022 19:31
@Florian14 Florian14 force-pushed the feature/fre/voice_message_persist_playback_state branch from 172ef1d to a73e707 Compare November 15, 2022 09:18
@Florian14 Florian14 changed the base branch from develop to feature/fre/voice_broadcast_live_indicator November 15, 2022 09:18
@sonarcloud
Copy link

sonarcloud bot commented Nov 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

82.0% 82.0% Coverage
0.0% 0.0% Duplication

@Florian14 Florian14 added the Z-NextRelease For issues and PRs which should be included in the NextRelease. label Nov 15, 2022
Copy link
Member

@giomfo giomfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved
I just noticed the playback positions will survive to a clear cache. Personally I don't know if this is good or not. We may wait before deciding to clear or not this information on clear cache.
Note: these information are already reset on a new app launch, which seems enough

Base automatically changed from feature/fre/voice_broadcast_live_indicator to develop November 15, 2022 16:25
@Florian14 Florian14 merged commit 6fc8c2c into develop Nov 15, 2022
@Florian14 Florian14 deleted the feature/fre/voice_message_persist_playback_state branch November 15, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Small PR with less than 20 updated lines Z-NextRelease For issues and PRs which should be included in the NextRelease.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants