Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save m.local_notification_settings.<device-id> event in account_data #7596

Closed
mnaturel opened this issue Nov 16, 2022 · 0 comments · Fixed by #7630
Closed

Save m.local_notification_settings.<device-id> event in account_data #7596

mnaturel opened this issue Nov 16, 2022 · 0 comments · Fixed by #7630
Assignees
Labels
A-Notifications T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@mnaturel
Copy link
Contributor

mnaturel commented Nov 16, 2022

Your use case

What would you like to do?

When background sync is used, on session start and each time we switch on background sync, if no event m.local_notification_settings.<device-id> exists, create and save a new one initialized with the current notification setting.
When switching from background sync to regular push notifications method, delete the created account data event.

Why would you like to do it?

To support remote toggle of push notifications for sessions using background sync.

How would you like to achieve it?

Adding a new check on the start of a session and when changing notification method.

Have you considered any alternatives?

No response

Additional context

No response

Are you willing to provide a PR?

Yes

@mnaturel mnaturel added A-Notifications T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements labels Nov 16, 2022
@mnaturel mnaturel self-assigned this Nov 16, 2022
@RiotRobot RiotRobot added this to Incoming in Issue triage Nov 16, 2022
@mnaturel mnaturel moved this from Incoming to Triaged in Issue triage Nov 16, 2022
@mnaturel mnaturel changed the title F-droid: save m.local_notification_settings.<device-id> event in account_data Save m.local_notification_settings.<device-id> event in account_data Nov 16, 2022
@mnaturel mnaturel changed the title Save m.local_notification_settings.<device-id> event in account_data Save m.local_notification_settings.<device-id> event in account_data (PSG-873) Nov 23, 2022
@mnaturel mnaturel changed the title Save m.local_notification_settings.<device-id> event in account_data (PSG-873) Save m.local_notification_settings.<device-id> event in account_data Nov 23, 2022
Issue triage automation moved this from Triaged to Closed Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Notifications T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
No open projects
1 participant