crypto migration tests #7645
Merged
crypto migration tests #7645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillCarsonFr
force-pushed
the
feature/bca/crypto_migration_test
branch
from
38c3dc6
to
45dd05a
Compare
bmarty
reviewed
Nov 28, 2022
| @@ -1 +1,2 @@ | |||
| **/snapshots/**/*.png filter=lfs diff=lfs merge=lfs -text | |||
| **/src/androidTest/assets/*.realm filter=lfs diff=lfs merge=lfs -text | |||
There was a problem hiding this comment.
Looks like the db file has been added without using git LFS, because the script validate_lfs.sh is complaining. Can you check please?
| @@ -0,0 +1,47 @@ | |||
| ## Testing database migration | |||
|
|
|||
There was a problem hiding this comment.
Thanks for the doc!
Not a big deal, but for consistency, it could be great to have a table of content.
Just manually add these 2 lines here:
<!--- TOC -->
<!--- END -->
and run ./gradlew knit to generate it.
docs/database_migration_test.md
Outdated
|
|
||
| Go to `data/data/im.vector.app.debug/files/<hash>/` | ||
| Pick the database you want to test (name can be found in SessionRealmConfigurationFactory): | ||
| - crypto_store.real for crypto |
There was a problem hiding this comment.
Suggested change
| - crypto_store.real for crypto | |
| - crypto_store.realm for crypto |
docs/database_migration_test.md
Outdated
| see `CryptoSanityMigrationTest` or `RealmSessionStoreMigration43Test` for sample tests. | ||
|
|
||
| There are already some databases in the assets folder. | ||
| The existing test will properly detect schema changes, and fail with such errors: |
There was a problem hiding this comment.
Suggested change
| The existing test will properly detect schema changes, and fail with such errors: | |
| The existing test will properly detect schema changes, and fail with such errors if a migration is missing: |
...d/src/androidTest/java/org/matrix/android/sdk/internal/database/CryptoSanityMigrationTest.kt
Outdated
Show resolved
Hide resolved
|
Please "Squash and merge" this PR, to avoid saving the big realm file to the git history. |
bmarty
approved these changes
Dec 7, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Added test to ensure that crypto database migration is done
Motivation and context
Screenshots / GIFs
Tests
Tested devices
Checklist